Basket::BackendAdapter::RedisBackend#redis_connection_from_host calls 'Basket.config' 3 times Open
host: Basket.config.redis_host,
port: Basket.config.redis_port,
db: Basket.config.redis_db
- Read upRead up
- Exclude checks
Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.
Reek implements a check for Duplicate Method Call.
Example
Here's a very much simplified and contrived example. The following method will report a warning:
def double_thing()
@other.thing + @other.thing
end
One quick approach to silence Reek would be to refactor the code thus:
def double_thing()
thing = @other.thing
thing + thing
end
A slightly different approach would be to replace all calls of double_thing
by calls to @other.double_thing
:
class Other
def double_thing()
thing + thing
end
end
The approach you take will depend on balancing other factors in your code.
Basket::BackendAdapter::RedisBackend has no descriptive comment Open
class RedisBackend < Basket::BackendAdapter
- Read upRead up
- Exclude checks
Classes and modules are the units of reuse and release. It is therefore considered good practice to annotate every class and module with a brief comment outlining its responsibilities.
Example
Given
class Dummy
# Do things...
end
Reek would emit the following warning:
test.rb -- 1 warning:
[1]:Dummy has no descriptive comment (IrresponsibleModule)
Fixing this is simple - just an explaining comment:
# The Dummy class is responsible for ...
class Dummy
# Do things...
end
Basket::BackendAdapter::RedisBackend#redis_connection_from_host doesn't depend on instance state (maybe move it to another class?) Open
def redis_connection_from_host
- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Basket::BackendAdapter::RedisBackend#redis_connection_from_url doesn't depend on instance state (maybe move it to another class?) Open
def redis_connection_from_url
- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Basket::BackendAdapter::RedisBackend#serialize_data doesn't depend on instance state (maybe move it to another class?) Open
def serialize_data(data)
- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.