Sign upLogin

nicknovitski/tabletop

View on GitHub
Star

Showing 8 of 8 total issues

Method roll has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def roll(params={})
      @dice.each do |die|

        meets_all_conditions = true
Severity: Minor
Found in lib/tabletop/dice_pool.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(init_dice)
      if init_dice.kind_of?(DicePool)
        return init_dice
      elsif init_dice.kind_of?(Array)
        @dice = init_dice
Severity: Minor
Found in lib/tabletop/dice_pool.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def check(p) #:nodoc:
      conditions_met = true
      
      if p.conditions[:>=] and sum < p.conditions[:>=]
        conditions_met = false
Severity: Minor
Found in lib/tabletop/roll.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(init_dice)
      if init_dice.kind_of?(DicePool)
        return init_dice
      elsif init_dice.kind_of?(Array)
        @dice = init_dice
Severity: Minor
Found in lib/tabletop/dice_pool.rb - About 1 hr to fix

    Method draw has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def draw(cards=1)
      raise DrawMoreCardsThanDeckHasError if cards > self.deck_size
      drawable_cards = self.clone
      if block_given?
        drawable_cards = drawable_cards.keep_if {|card,copies| yield(card,copies) }
    Severity: Minor
    Found in lib/tabletop/deck.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method roll has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def roll(opts={})
      @roll_modifier = opts[:modifier] ? opts[:modifier] : 0
      if @die_sides
        if opts[:pool] 
          @pool = opts[:pool].d(@die_sides)
    Severity: Minor
    Found in lib/tabletop/roll.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method d_notation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def d_notation
      fudge = nil
      result = {}
      @dice.each do |die|
        if die.instance_of?(FudgeDie)
    Severity: Minor
    Found in lib/tabletop/dice_pool.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(wanted, available)
      w_t, a_t = "token", "token"
      
      w_t << "s" if wanted > 1 or wanted == 0
    Severity: Minor
    Found in lib/tabletop/token.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language