nielsmaerten/peppermint

View on GitHub

Showing 15 of 15 total issues

File main.js has 408 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
    Ethereal by HTML5 UP
    html5up.net | @ajlkn
    Free for personal and commercial use under the CCA 3.0 license (html5up.net/license)
*/
Severity: Minor
Found in public/assets/js/main.js - About 5 hrs to fix

    Function normalizeWheel has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          var normalizeWheel = function (event) {
    
            var pixelStep = 10,
              lineHeight = 40,
              pageHeight = 800,
    Severity: Minor
    Found in public/assets/js/main.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            else {
      
              x = $target.offset().left - (Math.max(0, $window.width() - $target.outerWidth()) / 2);
              y = { scrollLeft: x };
      
      
      Severity: Major
      Found in public/assets/js/main.js and 1 other location - About 1 hr to fix
      public/assets/js/main.js on lines 613..618

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if (breakpoints.active('<=small')) {
      
              x = $target.offset().top - (Math.max(0, $window.height() - $target.outerHeight()) / 2);
              y = { scrollTop: x };
      
      
      Severity: Major
      Found in public/assets/js/main.js and 1 other location - About 1 hr to fix
      public/assets/js/main.js on lines 619..624

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      exports.newUserImage = functions.database
        .ref("users/{userId}/images/{postId}")
        .onCreate((data, context) => {
          console.log("New user image triggered.")
          return onNewUserImage(data, context)
      Severity: Major
      Found in src/peppermint.ts and 1 other location - About 1 hr to fix
      src/peppermint.ts on lines 27..32

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      exports.newMasterImage = functions.database
        .ref("masterlists/r/earthporn/{postId}")
        .onCreate((data, context) => {
          console.log("New master image triggered.")
          return onNewMasterImage(data, context)
      Severity: Major
      Found in src/peppermint.ts and 1 other location - About 1 hr to fix
      src/peppermint.ts on lines 34..39

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function getInterestedUsers has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public async getInterestedUsers(redditpost: RedditPost): Promise<User[]> {
          let users: User[] = []
          let presortedUsers = (await admin
            .database()
            .ref(Config.userListRef)
      Severity: Minor
      Found in src/clients/firebase-client.ts - About 1 hr to fix

        Function uploadImage has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public uploadImage(image: RedditPost) {
            return new Promise((resolve, reject) => {
              const chunks: Buffer[] = []
              this.getHttpOrHttps(
                image.imageUrl
        Severity: Minor
        Found in src/clients/dropbox-client.ts - About 1 hr to fix

          Function dropHandler has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          function dropHandler(ev) {
            console.log('File(s) dropped');
          
            // Prevent default behavior (Prevent file from being opened)
            ev.preventDefault();
          Severity: Minor
          Found in public/src/lookup.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      case 37:
                        $document.scrollLeft($document.scrollLeft() - settings.keyboardShortcuts.distance);
                        scrolled = true;
                        break;
          Severity: Minor
          Found in public/assets/js/main.js and 1 other location - About 35 mins to fix
          public/assets/js/main.js on lines 191..194

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              await admin
                .database()
                .ref(`${Config.masterListsRef}/${Config.subreddit}/${postId}`)
                .update({
                  height: properties.height,
          Severity: Minor
          Found in src/clients/firebase-client.ts and 2 other locations - About 35 mins to fix
          src/clients/firebase-client.ts on lines 35..38
          src/clients/firebase-client.ts on lines 166..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              const postUrlSnapshot = await admin
                .database()
                .ref(`${Config.masterListsRef}/${Config.subreddit}/${imageId}/postUrl`)
                .once("value")
          Severity: Minor
          Found in src/clients/firebase-client.ts and 2 other locations - About 35 mins to fix
          src/clients/firebase-client.ts on lines 35..38
          src/clients/firebase-client.ts on lines 56..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      case 39:
                        $document.scrollLeft($document.scrollLeft() + settings.keyboardShortcuts.distance);
                        scrolled = true;
                        break;
          Severity: Minor
          Found in public/assets/js/main.js and 1 other location - About 35 mins to fix
          public/assets/js/main.js on lines 185..188

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              await admin
                .database()
                .ref(`${Config.masterListsRef}/${Config.subreddit}/${postId}`)
                .remove()
          Severity: Minor
          Found in src/clients/firebase-client.ts and 2 other locations - About 35 mins to fix
          src/clients/firebase-client.ts on lines 56..63
          src/clients/firebase-client.ts on lines 166..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function getInterestedUsers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            public async getInterestedUsers(redditpost: RedditPost): Promise<User[]> {
              let users: User[] = []
              let presortedUsers = (await admin
                .database()
                .ref(Config.userListRef)
          Severity: Minor
          Found in src/clients/firebase-client.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language