nigroup/nideep

View on GitHub
nideep/datasets/amfed/test_amfed.py

Summary

Maintainability
D
1 day
Test Coverage

Function test_intersection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def test_intersection(self):
        amfed = AMFED(self.dir_tmp)
        found_entities = amfed.find_data_intersection()

        assert_equals(len(found_entities), 2)
Severity: Minor
Found in nideep/datasets/amfed/test_amfed.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

def generate_random_entity_name():
    return ''.join(random.SystemRandom().choice(string.ascii_uppercase + string.digits) for _ in range(9))
Severity: Major
Found in nideep/datasets/amfed/test_amfed.py and 1 other location - About 1 hr to fix
nideep/datasets/amfed/test_entity.py on lines 17..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        write_dummy_txt(os.path.join(self.dir_landmarks, self.entity_names[3] + AMFED.SUFFIX_LANDMARKS + '.txt'))
Severity: Major
Found in nideep/datasets/amfed/test_amfed.py and 6 other locations - About 1 hr to fix
nideep/datasets/amfed/test_amfed.py on lines 45..45
nideep/datasets/amfed/test_amfed.py on lines 46..46
nideep/datasets/amfed/test_amfed.py on lines 47..47
nideep/datasets/amfed/test_amfed.py on lines 48..48
nideep/datasets/amfed/test_amfed.py on lines 50..50
nideep/datasets/amfed/test_amfed.py on lines 52..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        write_dummy_txt(os.path.join(self.dir_landmarks, self.entity_names[5] + AMFED.SUFFIX_LANDMARKS + '.txt'))
Severity: Major
Found in nideep/datasets/amfed/test_amfed.py and 6 other locations - About 1 hr to fix
nideep/datasets/amfed/test_amfed.py on lines 45..45
nideep/datasets/amfed/test_amfed.py on lines 46..46
nideep/datasets/amfed/test_amfed.py on lines 47..47
nideep/datasets/amfed/test_amfed.py on lines 48..48
nideep/datasets/amfed/test_amfed.py on lines 50..50
nideep/datasets/amfed/test_amfed.py on lines 51..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        write_dummy_txt(os.path.join(self.dir_au_labels, self.entity_names[4] + AMFED.SUFFIX_AU_LABELS + '.csv'))
Severity: Major
Found in nideep/datasets/amfed/test_amfed.py and 6 other locations - About 1 hr to fix
nideep/datasets/amfed/test_amfed.py on lines 45..45
nideep/datasets/amfed/test_amfed.py on lines 46..46
nideep/datasets/amfed/test_amfed.py on lines 47..47
nideep/datasets/amfed/test_amfed.py on lines 50..50
nideep/datasets/amfed/test_amfed.py on lines 51..51
nideep/datasets/amfed/test_amfed.py on lines 52..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        write_dummy_txt(os.path.join(self.dir_au_labels, self.entity_names[2] + AMFED.SUFFIX_AU_LABELS + '.csv'))
Severity: Major
Found in nideep/datasets/amfed/test_amfed.py and 6 other locations - About 1 hr to fix
nideep/datasets/amfed/test_amfed.py on lines 45..45
nideep/datasets/amfed/test_amfed.py on lines 47..47
nideep/datasets/amfed/test_amfed.py on lines 48..48
nideep/datasets/amfed/test_amfed.py on lines 50..50
nideep/datasets/amfed/test_amfed.py on lines 51..51
nideep/datasets/amfed/test_amfed.py on lines 52..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        write_dummy_txt(os.path.join(self.dir_au_labels, self.entity_names[3] + AMFED.SUFFIX_AU_LABELS + '.csv'))
Severity: Major
Found in nideep/datasets/amfed/test_amfed.py and 6 other locations - About 1 hr to fix
nideep/datasets/amfed/test_amfed.py on lines 45..45
nideep/datasets/amfed/test_amfed.py on lines 46..46
nideep/datasets/amfed/test_amfed.py on lines 48..48
nideep/datasets/amfed/test_amfed.py on lines 50..50
nideep/datasets/amfed/test_amfed.py on lines 51..51
nideep/datasets/amfed/test_amfed.py on lines 52..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        write_dummy_txt(os.path.join(self.dir_au_labels, self.entity_names[1] + AMFED.SUFFIX_AU_LABELS + '.csv'))
Severity: Major
Found in nideep/datasets/amfed/test_amfed.py and 6 other locations - About 1 hr to fix
nideep/datasets/amfed/test_amfed.py on lines 46..46
nideep/datasets/amfed/test_amfed.py on lines 47..47
nideep/datasets/amfed/test_amfed.py on lines 48..48
nideep/datasets/amfed/test_amfed.py on lines 50..50
nideep/datasets/amfed/test_amfed.py on lines 51..51
nideep/datasets/amfed/test_amfed.py on lines 52..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        write_dummy_txt(os.path.join(self.dir_landmarks, self.entity_names[2] + AMFED.SUFFIX_LANDMARKS + '.txt'))
Severity: Major
Found in nideep/datasets/amfed/test_amfed.py and 6 other locations - About 1 hr to fix
nideep/datasets/amfed/test_amfed.py on lines 45..45
nideep/datasets/amfed/test_amfed.py on lines 46..46
nideep/datasets/amfed/test_amfed.py on lines 47..47
nideep/datasets/amfed/test_amfed.py on lines 48..48
nideep/datasets/amfed/test_amfed.py on lines 51..51
nideep/datasets/amfed/test_amfed.py on lines 52..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    assert_equals(a, os.path.join(self.dir_au_labels, e + AMFED.SUFFIX_AU_LABELS + '.csv'))
Severity: Minor
Found in nideep/datasets/amfed/test_amfed.py and 1 other location - About 35 mins to fix
nideep/datasets/amfed/test_amfed.py on lines 80..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    assert_equals(l, os.path.join(self.dir_landmarks, e + AMFED.SUFFIX_LANDMARKS + '.txt'))
Severity: Minor
Found in nideep/datasets/amfed/test_amfed.py and 1 other location - About 35 mins to fix
nideep/datasets/amfed/test_amfed.py on lines 79..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        write_dummy_txt(os.path.join(self.dir_videos, self.entity_names[3] + '.flv'))
Severity: Minor
Found in nideep/datasets/amfed/test_amfed.py and 2 other locations - About 30 mins to fix
nideep/datasets/amfed/test_amfed.py on lines 41..41
nideep/datasets/amfed/test_amfed.py on lines 42..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        write_dummy_txt(os.path.join(self.dir_videos, self.entity_names[0] + '.flv'))
Severity: Minor
Found in nideep/datasets/amfed/test_amfed.py and 2 other locations - About 30 mins to fix
nideep/datasets/amfed/test_amfed.py on lines 42..42
nideep/datasets/amfed/test_amfed.py on lines 43..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        write_dummy_txt(os.path.join(self.dir_videos, self.entity_names[2] + '.flv'))
Severity: Minor
Found in nideep/datasets/amfed/test_amfed.py and 2 other locations - About 30 mins to fix
nideep/datasets/amfed/test_amfed.py on lines 41..41
nideep/datasets/amfed/test_amfed.py on lines 43..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status