Sign upLogin

nigroup/nideep

View on GitHub
Star
nideep/datasets/celeba/celeba.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function as_numpy_array has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def as_numpy_array(self, projection=['Smiling'], train_proportion=0.8, imbalance_proportion=None, oversample=False,
                       filter_by=None, cache=True):
        tmp_train_labels = os.path.join(self.cache_dir, self.TMP_TRAIN_LABELS)
        tmp_test_labels = os.path.join(self.cache_dir, self.TMP_TEST_LABELS)
        tmp_train_fnames = os.path.join(self.cache_dir, self.TMP_TRAIN_FILES)
Severity: Minor
Found in nideep/datasets/celeba/celeba.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function as_numpy_array has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def as_numpy_array(self, projection=['Smiling'], train_proportion=0.8, imbalance_proportion=None, oversample=False,
Severity: Minor
Found in nideep/datasets/celeba/celeba.py - About 45 mins to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if cache_dir and not os.path.isdir(cache_dir):
            os.makedirs(cache_dir)
            self.logger.info("Creating cache directory at %s" % os.path.abspath(self.cache_dir))
    Severity: Major
    Found in nideep/datasets/celeba/celeba.py and 1 other location - About 2 hrs to fix
    nideep/datasets/amfed/amfed.py on lines 178..180

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

            if not os.path.isdir(self.dir_imgs):
            self.logger.warning("Image directory does not exist (%s)" % self.dir_imgs)
    Severity: Major
    Found in nideep/datasets/celeba/celeba.py and 6 other locations - About 55 mins to fix
    nideep/datasets/amfed/amfed.py on lines 182..183
    nideep/datasets/amfed/amfed.py on lines 185..186
    nideep/datasets/amfed/amfed.py on lines 193..194
    nideep/datasets/amfed/entity.py on lines 146..147
    nideep/datasets/amfed/entity.py on lines 149..150
    nideep/datasets/amfed/entity.py on lines 152..153

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status