nigroup/nideep

View on GitHub
nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py

Summary

Maintainability
F
1 wk
Test Coverage

File test_nyudv2_to_lmdb.py has 255 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from nose.tools import assert_false, assert_greater, assert_is_instance, \
    assert_list_equal, assert_raises, assert_true, assert_equal
from mock import patch
import os
import tempfile
Severity: Minor
Found in nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py - About 2 hrs to fix

    Function test_big_arr_to_arrs_single has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def test_big_arr_to_arrs_single(self):
    
            x = np.array([[[ 1, 2, 3],
                           [ 4, 5, 6]
                           ],
    Severity: Minor
    Found in nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        @patch('nideep.datasets.nyudv2.nyudv2_to_lmdb.to_lmdb.caffe')
        @patch('nideep.datasets.nyudv2.nyudv2_to_lmdb.to_lmdb.caffe.proto.caffe_pb2.Datum')
        def test_nyudv2_to_lmdb_info_hdf5(self, mock_dat, mock_caffe):
    
            # mock caffe calls made by our module
    Severity: Major
    Found in nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py and 2 other locations - About 3 days to fix
    nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py on lines 163..207
    nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py on lines 255..299

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 347.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        @patch('nideep.datasets.nyudv2.nyudv2_to_lmdb.to_lmdb.caffe')
        @patch('nideep.datasets.nyudv2.nyudv2_to_lmdb.to_lmdb.caffe.proto.caffe_pb2.Datum')
        def test_nyudv2_to_lmdb_info_mat73(self, mock_dat, mock_caffe):
    
            # mock caffe calls made by our module
    Severity: Major
    Found in nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py and 2 other locations - About 3 days to fix
    nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py on lines 209..253
    nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py on lines 255..299

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 347.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        @patch('nideep.datasets.nyudv2.nyudv2_to_lmdb.to_lmdb.caffe')
        @patch('nideep.datasets.nyudv2.nyudv2_to_lmdb.to_lmdb.caffe.proto.caffe_pb2.Datum')
        def test_nyudv2_to_lmdb_info_hdf5_2(self, mock_dat, mock_caffe):
    
            # mock caffe calls made by our module
    Severity: Major
    Found in nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py and 2 other locations - About 3 days to fix
    nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py on lines 163..207
    nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py on lines 209..253

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 347.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @classmethod
        def setup_class(self):
    
            self.dir_tmp = tempfile.mkdtemp()
    
    
    Severity: Major
    Found in nideep/datasets/nyudv2/test_nyudv2_to_lmdb.py and 1 other location - About 6 hrs to fix
    nideep/iow/test_copy_lmdb.py on lines 21..39

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status