nikoksr/notify

View on GitHub

Showing 6 of 6 total issues

Method Service.send has 7 return statements (exceeds 4 allowed).
Open

func (s *Service) send(ctx context.Context, serverURL, subject, content string) error {
    if serverURL == "" {
        return errors.New("server url is empty")
    }

Severity: Major
Found in service/bark/bark.go - About 45 mins to fix

    Function setupLoginService has 6 return statements (exceeds 4 allowed).
    Open

    func setupLoginService(url string, msgService *http.Service) *http.Service {
        // create another new http client for login request call.
        httpService := http.New()
    
        // append login path for the given mattermost server with custom payload builder.
    Severity: Major
    Found in service/mattermost/mattermost.go - About 40 mins to fix

      Function New has 5 return statements (exceeds 4 allowed).
      Open

      func New(cOpts *ClientOptions, mOpts *MessageOptions) (*Service, error) {
          if cOpts == nil {
              return nil, errors.New("client-options cannot be nil")
          }
      
      
      Severity: Major
      Found in service/plivo/plivo.go - About 35 mins to fix

        Method Service.do has 5 return statements (exceeds 4 allowed).
        Open

        func (s *Service) do(req *http.Request) error {
            // Execute all pre-send hooks in order.
            if err := s.doPreSendHooks(req); err != nil {
                return fmt.Errorf("pre-send hooks: %w", err)
            }
        Severity: Major
        Found in service/http/http.go - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func WithCredentialsFile(filename string) Option {
              return func(s *Service) error {
                  client, ok := s.client.(*fcm.Client)
                  if !ok {
                      return errors.New("client is not of type *fcm.Client")
          Severity: Minor
          Found in service/fcm/fcm.go and 1 other location - About 35 mins to fix
          service/fcm/fcm.go on lines 46..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func WithProjectID(projectID string) Option {
              return func(s *Service) error {
                  client, ok := s.client.(*fcm.Client)
                  if !ok {
                      return errors.New("client is not of type *fcm.Client")
          Severity: Minor
          Found in service/fcm/fcm.go and 1 other location - About 35 mins to fix
          service/fcm/fcm.go on lines 34..43

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language