Sign upLogin

nikrolls/angular-nz-input-formats

View on GitHub
Star
src/simple-input-mask.directive.ts

Summary

Maintainability
B
4 hrs
Test Coverage

SimpleInputMask has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

    export class SimpleInputMask {
        // Directive properties
        public require = 'ngModel';
        public restrict = 'A';
        public link: Function = null;
Severity: Minor
Found in src/simple-input-mask.directive.ts - About 2 hrs to fix

    Function link has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

                        scope: angular.IScope, elem: angular.IAugmentedJQuery, attrs: angular.IAttributes,
                    ctrl: any, transclude: angular.ITranscludeFunction
    Severity: Minor
    Found in src/simple-input-mask.directive.ts - About 35 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      link: function link(
                    scope: angular.IScope, elem: angular.IAugmentedJQuery, attrs: angular.IAttributes,
                    ctrl: any, transclude: angular.ITranscludeFunction
                ) {
                    var inst = new T();
      Severity: Minor
      Found in src/simple-input-mask.directive.ts and 1 other location - About 45 mins to fix
      src/simple-input-mask.directive.ts on lines 76..92

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              protected doLink(
            scope: angular.IScope, elem: angular.IAugmentedJQuery, attrs: angular.IAttributes, ctrl: any,
            transclude: angular.ITranscludeFunction
        ): void {
            this.scope = scope;
      Severity: Minor
      Found in src/simple-input-mask.directive.ts and 1 other location - About 45 mins to fix
      src/simple-input-mask.directive.ts on lines 65..72

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

                  if (angular.isUndefined(value) || value === null || value === '' || value !== value /*NaN*/) {
                // No validation for an undefined model value
                return true;
            }
      Severity: Major
      Found in src/simple-input-mask.directive.ts and 3 other locations - About 40 mins to fix
      src/nz-bank-number.directive.ts on lines 55..58
      src/nz-ird-number.directive.ts on lines 36..39
      src/nz-phone-number.directive.ts on lines 87..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status