Sign upLogin

niwa99/Tower-Defense

View on GitHub
Star
app/src/main/java/de/dhbw/game/Game.java

Summary

Maintainability
F
4 days
Test Coverage

Method generateButtonsOnMap has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring.
Open

    private void generateButtonsOnMap() {

        List<Button> mapButtons = new ArrayList<>();
        View.OnClickListener listener = view -> {
            Optional<Button> button = mapButtons.stream().filter(e -> view.getTransitionName().equals(e.getTransitionName())).findFirst();
Severity: Minor
Found in app/src/main/java/de/dhbw/game/Game.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Game.java has 512 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package de.dhbw.game;

import android.app.AlertDialog;
import android.content.Intent;
import android.view.View;
Severity: Major
Found in app/src/main/java/de/dhbw/game/Game.java - About 1 day to fix

    Game has 45 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class Game {

    private GameActivity gameActivity;

    private MapStructure mapStructure;
    Severity: Minor
    Found in app/src/main/java/de/dhbw/game/Game.java - About 6 hrs to fix

      Method generateButtonsOnMap has 93 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void generateButtonsOnMap() {

        List<Button> mapButtons = new ArrayList<>();
        View.OnClickListener listener = view -> {
            Optional<Button> button = mapButtons.stream().filter(e -> view.getTransitionName().equals(e.getTransitionName())).findFirst();
      Severity: Major
      Found in app/src/main/java/de/dhbw/game/Game.java - About 3 hrs to fix

        Method buildTower has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void buildTower(TowerType type, int level, Position pos) {
        if (subMoney(type.getPrice()) && getMapStructure().getField(pos).getFieldDescription() == FieldDescription.FREE) {
            switch(type) {
                case ARTILLERY:
                    TowerArtillery newArtillery = new TowerArtillery(getMapStructure().getField(pos), level, gameActivity);
        Severity: Minor
        Found in app/src/main/java/de/dhbw/game/Game.java - About 1 hr to fix

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

                          case ASSAULTLASER:
                    TowerLaser newAssaultLaser = new TowerLaser(getMapStructure().getField(pos), level, gameActivity);
                    getMatchField().addTower(newAssaultLaser);
                    getMapStructure().getField(pos).setFieldDescription(FieldDescription.TOWER);
                    break;
          Severity: Major
          Found in app/src/main/java/de/dhbw/game/Game.java and 4 other locations - About 35 mins to fix
          app/src/main/java/de/dhbw/game/Game.java on lines 257..261
          app/src/main/java/de/dhbw/game/Game.java on lines 262..266
          app/src/main/java/de/dhbw/game/Game.java on lines 267..271
          app/src/main/java/de/dhbw/game/Game.java on lines 272..276

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

                          case ARTILLERY:
                    TowerArtillery newArtillery = new TowerArtillery(getMapStructure().getField(pos), level, gameActivity);
                    getMatchField().addTower(newArtillery);
                    getMapStructure().getField(pos).setFieldDescription(FieldDescription.TOWER);
                    break;
          Severity: Major
          Found in app/src/main/java/de/dhbw/game/Game.java and 4 other locations - About 35 mins to fix
          app/src/main/java/de/dhbw/game/Game.java on lines 262..266
          app/src/main/java/de/dhbw/game/Game.java on lines 267..271
          app/src/main/java/de/dhbw/game/Game.java on lines 272..276
          app/src/main/java/de/dhbw/game/Game.java on lines 277..281

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

                          case FREEZER:
                    TowerFreezer newFreezer = new TowerFreezer(getMapStructure().getField(pos), level, gameActivity);
                    getMatchField().addTower(newFreezer);
                    getMapStructure().getField(pos).setFieldDescription(FieldDescription.TOWER);
                    break;
          Severity: Major
          Found in app/src/main/java/de/dhbw/game/Game.java and 4 other locations - About 35 mins to fix
          app/src/main/java/de/dhbw/game/Game.java on lines 257..261
          app/src/main/java/de/dhbw/game/Game.java on lines 267..271
          app/src/main/java/de/dhbw/game/Game.java on lines 272..276
          app/src/main/java/de/dhbw/game/Game.java on lines 277..281

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

                          case BOOMBASTIC:
                    TowerBoombastic newBoombastic = new TowerBoombastic(getMapStructure().getField(pos), level, gameActivity);
                    getMatchField().addTower(newBoombastic);
                    getMapStructure().getField(pos).setFieldDescription(FieldDescription.TOWER);
                    break;
          Severity: Major
          Found in app/src/main/java/de/dhbw/game/Game.java and 4 other locations - About 35 mins to fix
          app/src/main/java/de/dhbw/game/Game.java on lines 257..261
          app/src/main/java/de/dhbw/game/Game.java on lines 262..266
          app/src/main/java/de/dhbw/game/Game.java on lines 272..276
          app/src/main/java/de/dhbw/game/Game.java on lines 277..281

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

                          case PLASMARIZER:
                    TowerPlasmarizer newPlasmarizer = new TowerPlasmarizer(getMapStructure().getField(pos), level, gameActivity);
                    getMatchField().addTower(newPlasmarizer);
                    getMapStructure().getField(pos).setFieldDescription(FieldDescription.TOWER);
                    break;
          Severity: Major
          Found in app/src/main/java/de/dhbw/game/Game.java and 4 other locations - About 35 mins to fix
          app/src/main/java/de/dhbw/game/Game.java on lines 257..261
          app/src/main/java/de/dhbw/game/Game.java on lines 262..266
          app/src/main/java/de/dhbw/game/Game.java on lines 267..271
          app/src/main/java/de/dhbw/game/Game.java on lines 277..281

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status