Sign upLogin

niwa99/Tower-Defense

View on GitHub
Star
app/src/main/java/de/dhbw/map/structure/MapStructure.java

Summary

Maintainability
D
1 day
Test Coverage

Method calculatePath has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    public static int calculatePath(float xCoord, float yCoord) {

        int pathImage = DRAWABLE_PATH_HORIZONTAL;
        int pathNumber = getPathNumber(xCoord, yCoord);
        if (pathNumber != 0 && pathNumber != 20) {
Severity: Minor
Found in app/src/main/java/de/dhbw/map/structure/MapStructure.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createPath has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private FieldDescription[][] createPath() {
        // There is only one fixed Path with the Coordinates generated as following
        FieldDescription[][] fieldDescription = new FieldDescription[AMOUNT_COLUMNS][AMOUNT_ROWS];
        boolean spawn = true;
        for (int i = 0; i < 11; i++) {
Severity: Minor
Found in app/src/main/java/de/dhbw/map/structure/MapStructure.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method calculatePath has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static int calculatePath(float xCoord, float yCoord) {

        int pathImage = DRAWABLE_PATH_HORIZONTAL;
        int pathNumber = getPathNumber(xCoord, yCoord);
        if (pathNumber != 0 && pathNumber != 20) {
Severity: Minor
Found in app/src/main/java/de/dhbw/map/structure/MapStructure.java - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                            if (spawn) {
                            fieldDescription[i][j] = FieldDescription.SPAWN;
                            spawn = false;
                        } else {
                            fieldDescription[i][j] = FieldDescription.PATH;
    Severity: Major
    Found in app/src/main/java/de/dhbw/map/structure/MapStructure.java - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  } else {
                if (path[pathNumber].getX() < path[pathNumber + 1].getX()) {
                    if (path[pathNumber].getY() < path[pathNumber - 1].getY()) {
                        pathImage = Constants.DRAWABLE_PATH_RIGHT_DOWN;
                    } else {
      Severity: Major
      Found in app/src/main/java/de/dhbw/map/structure/MapStructure.java and 1 other location - About 1 hr to fix
      app/src/main/java/de/dhbw/map/structure/MapStructure.java on lines 86..100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 126.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  } else if (path[pathNumber].getY() == path[pathNumber - 1].getY()) {
                if (path[pathNumber].getY() < path[pathNumber + 1].getY()) {
                    if (path[pathNumber].getX() < path[pathNumber - 1].getX()) {
                        pathImage = Constants.DRAWABLE_PATH_RIGHT_DOWN;
                    } else {
      Severity: Major
      Found in app/src/main/java/de/dhbw/map/structure/MapStructure.java and 1 other location - About 1 hr to fix
      app/src/main/java/de/dhbw/map/structure/MapStructure.java on lines 100..114

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 126.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (path[pathNumber].getX() == path[pathNumber - 1].getX() && path[pathNumber].getX() == path[pathNumber + 1].getX()) {
      Severity: Minor
      Found in app/src/main/java/de/dhbw/map/structure/MapStructure.java and 1 other location - About 35 mins to fix
      app/src/main/java/de/dhbw/map/structure/MapStructure.java on lines 84..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  } else if (path[pathNumber].getY() == path[pathNumber - 1].getY() && path[pathNumber].getY() == path[pathNumber + 1].getY()) {
      Severity: Minor
      Found in app/src/main/java/de/dhbw/map/structure/MapStructure.java and 1 other location - About 35 mins to fix
      app/src/main/java/de/dhbw/map/structure/MapStructure.java on lines 82..82

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status