Sign upLogin

njbarrett/laravel-postgis

View on GitHub
Star

Showing 12 of 12 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function __construct(array $linestrings)
    {
        if (count($linestrings) < 1) {
            throw new InvalidArgumentException('$linestrings must contain at least one entry');
        }
Severity: Major
Found in src/Geometries/LineStringCollection.php and 2 other locations - About 1 hr to fix
src/Geometries/MultiPoint.php on lines 11..23
src/Geometries/PointCollection.php on lines 24..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function __construct(array $points)
    {
        if (count($points) < 1) {
            throw new InvalidArgumentException('$points must contain at least one entry');
        }
Severity: Major
Found in src/Geometries/MultiPoint.php and 2 other locations - About 1 hr to fix
src/Geometries/LineStringCollection.php on lines 18..33
src/Geometries/PointCollection.php on lines 24..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function __construct(array $points)
    {
        if (count($points) < 2) {
            throw new InvalidArgumentException('$points must contain at least two entries');
        }
Severity: Major
Found in src/Geometries/PointCollection.php and 2 other locations - About 1 hr to fix
src/Geometries/LineStringCollection.php on lines 18..33
src/Geometries/MultiPoint.php on lines 11..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getPostgisType has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function getPostgisType($key)
    {
        $default = [
            'geomtype' => 'geography',
            'srid' => 4326
Severity: Minor
Found in src/Eloquent/PostgisTrait.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getWKTClass has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getWKTClass($value)
    {
        $left = strpos($value, '(');
        $type = trim(substr($value, 0, $left));
Severity: Minor
Found in src/Geometries/Geometry.php - About 1 hr to fix

    Function upsert has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function upsert(array $values, $uniqueBy, $update = null)
    {
        foreach ($values as &$row) {
            foreach ($row as $column => &$value) {
                if ($value instanceof GeometryInterface) {
    Severity: Minor
    Found in src/Eloquent/Builder.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function performInsert has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function performInsert(EloquentBuilder $query, array $options = [])
    {
        foreach ($this->attributes as $key => $value) {
            if ($value instanceof GeometryInterface) {
                $this->geometries[$key] = $value; //Preserve the geometry objects prior to the insert
    Severity: Minor
    Found in src/Eloquent/PostgisTrait.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method createConnection has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function createConnection($driver, $connection, $database, $prefix = '', array $config = [])
    Severity: Minor
    Found in src/Connectors/ConnectionFactory.php - About 35 mins to fix

      Function update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function update(array $values)
    {
        foreach ($values as $key => &$value) {
            if ($value instanceof GeometryInterface) {
                if (is_null($this->model)) {
      Severity: Minor
      Found in src/Eloquent/Builder.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return MultiPolygon::class;
      Severity: Major
      Found in src/Geometries/Geometry.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return MultiLineString::class;
        Severity: Major
        Found in src/Geometries/Geometry.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return GeometryCollection::class;
          Severity: Major
          Found in src/Geometries/Geometry.php - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language