njomeau/zuluzulu

View on GitHub
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/EventFragment.java

Summary

Maintainability
B
4 hrs
Test Coverage

File EventFragment.java has 257 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package ch.epfl.sweng.zuluzulu.fragments;

import android.app.DatePickerDialog;
import android.os.Bundle;
import android.support.annotation.NonNull;
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/EventFragment.java - About 2 hrs to fix

    Method onCreateView has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
        public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
            View view = inflater.inflate(R.layout.fragment_event, container, false);
            listview_event = view.findViewById(R.id.event_fragment_listview);
            listview_event.setAdapter(event_adapter);

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          public static EventFragment newInstance(User user) {
              if(user == null)
                  throw new IllegalArgumentException("user can't be null");
              EventFragment fragment = new EventFragment();
              Bundle args = new Bundle();
      app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/AssociationFragment.java on lines 52..60
      app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/CalendarFragment.java on lines 54..62
      app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/ChannelFragment.java on lines 60..68
      app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/MainFragment.java on lines 60..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status