lib/oink/reports/active_record_instantiation_report.rb
Assignment Branch Condition size for print is too high. [58.19/20] Open
Open
def print(output)
output.puts "---- OINK FOR ACTIVERECORD ----"
output.puts "THRESHOLD: #{@threshold} Active Record objects per request\n"
output.puts "\n-- REQUESTS --\n" if @format == :verbose- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Method print has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring. Open
Open
def print(output)
output.puts "---- OINK FOR ACTIVERECORD ----"
output.puts "THRESHOLD: #{@threshold} Active Record objects per request\n"
output.puts "\n-- REQUESTS --\n" if @format == :verbose- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method print has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def print(output)
output.puts "---- OINK FOR ACTIVERECORD ----"
output.puts "THRESHOLD: #{@threshold} Active Record objects per request\n"
output.puts "\n-- REQUESTS --\n" if @format == :verbose