Sign upLogin

node-xyz/xyz-core

View on GitHub
Star

Showing 107 of 107 total issues

Function _genericTransportInvoke has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function _genericTransportInvoke (params: IServDiscMwParam, next, end, xyz: XYZ) {
  const targets = params.targets
  const transport = xyz.serviceRepository.transport
  const responseCallback = params.responseCallback
  const logger = xyz.logger
Severity: Minor
Found in src/Service/Middleware/service.generic.transport.ts - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        } else if (type === 'UDP') {
      server = new UDPServer(this.xyz, port)
      this.servers[Number(port)] = server
      CONFIG.addServer({type: type, port: port, event: e})
      return server
    Severity: Major
    Found in src/Transport/Transport.ts and 1 other location - About 1 hr to fix
    src/Transport/Transport.ts on lines 123..136

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (type === 'HTTP') {
      server = new HTTPServer(this.xyz, port)
      this.servers[Number(port)] = server
      CONFIG.addServer({type: type, port: port, event: e})
      return server
    Severity: Major
    Found in src/Transport/Transport.ts and 1 other location - About 1 hr to fix
    src/Transport/Transport.ts on lines 128..136

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function match has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        match: function (path, serializedTree) {
        var matches = [];
        var pathToken = path.split('/');
        var pathIndex = 0;
        var pathTree = serializedTree;
    Severity: Minor
    Found in built/Service/path.js - About 1 hr to fix

      Function send has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          Transport.prototype.send = function (opt, responseCallback) {
        opt.route = opt.route || 'CALL';
        if (!this.routes[opt.route]) {
            Logger_1.logger.error("attempting to send message in route " + opt.route + ". DOES NOT EXIST");
            responseCallback('outgoing message route not found', null);
      Severity: Minor
      Found in built/Transport/Transport.js - About 1 hr to fix

        Function send has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          send (opt: ITransportSendMessageParams, responseCallback?) {
    opt.route = opt.route || 'CALL'

    if (!this.routes[opt.route]) {
      logger.error(`attempting to send message in route ${opt.route}. DOES NOT EXIST`)
        Severity: Minor
        Found in src/Transport/Transport.ts - About 1 hr to fix

          Function setSelfConf has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            setSelfConf: (aConf, cmdLineArgs) => {
    logger.info('CONFIG :: Setting default selfConf')
    selfConf = CONSTANTS.defaultConfig.selfConf
    logger.info('CONFIG :: Reading selfConf from user')
    selfConf = MergeRecursive(selfConf, aConf)
          Severity: Minor
          Found in src/Config/config.global.ts - About 1 hr to fix

            Function xyzGeneric has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            function xyzGeneric(prefix) {
    if (prefix === void 0) { prefix = '--xyz-'; }
    var args = process.argv;
    var _args = {};
    for (var idx = 2; idx < args.length; idx++) {
            Severity: Minor
            Found in built/Util/commandline.parser.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function HTTPServer has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            var HTTPServer = (function (_super) {
    __extends(HTTPServer, _super);
    /**
     * Creates a new HTTP server
     * @param xyz {Object} a reference to the curretn xyz object. will be filled automatically.
            Severity: Minor
            Found in built/Transport/HTTP/http.server.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function match has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              match (path, serializedTree) {
    let matches = []
    let pathToken = path.split('/')
    let pathIndex = 0
    let pathTree = serializedTree
            Severity: Minor
            Found in src/Service/path.ts - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  logger.verbose(wrapper('bold', 'BROADCAST GLOBAL') + " :: sending message to " + calls.map(function (o) { return o.node + ':' + o.match; }) + ",  ");
              Severity: Major
              Found in built/Service/Middleware/service.broadcast.global.js and 1 other location - About 1 hr to fix
              built/Service/Middleware/service.broadcast.local.js on lines 27..27

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  logger.verbose(wrapper('bold', 'BROADCAST LOCAL') + " :: sending message to " + calls.map(function (o) { return o.node + ':' + o.match; }) + ",  ");
              Severity: Major
              Found in built/Service/Middleware/service.broadcast.local.js and 1 other location - About 1 hr to fix
              built/Service/Middleware/service.broadcast.global.js on lines 21..21

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function _loop_1 has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      var _loop_1 = function (node) {
            SR.transport.send({
                route: 'PING',
                node: node
            }, function (err, body, res) {
              Severity: Minor
              Found in built/Bootstrap/ping.basic.js - About 1 hr to fix

                Function _basicPingBootstrap has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                export default function _basicPingBootstrap (xyz: INodeXYZ, event, port) {
  let Util = xyz.Util
  let wrapper = Util.wrapper
  let logger = xyz.logger
  let CONFIG = xyz.CONFIG
                Severity: Minor
                Found in src/Bootstrap/ping.basic.ts - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function roundRobinSendStrategy has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                let roundRobinSendStrategy = function (params, next, done, xyz) {
  let servicePath = params[0].servicePath
  // let userPayload = params[0].payload
  let responseCallback = params[1]
  let route = params[0].route
                Severity: Minor
                Found in examples/load-balancer/round.robin.send.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function xyzGeneric has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                export function xyzGeneric (prefix = '--xyz-') {
  let args = process.argv
  let _args = {}
  for (let idx = 2; idx < args.length; idx++) {
    let arg = args[idx]
                Severity: Minor
                Found in src/Util/commandline.parser.ts - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _basicPingBootstrap has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                function _basicPingBootstrap(xyz, event, port) {
    var Util = xyz.Util;
    var wrapper = Util.wrapper;
    var logger = xyz.logger;
    var CONFIG = xyz.CONFIG;
                Severity: Minor
                Found in built/Bootstrap/ping.basic.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function UDPServer has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function UDPServer(xyz, port) {
        var _this = _super.call(this) || this;
        _this.port = port;
        _this.xyz = xyz;
        /**
                Severity: Minor
                Found in built/Transport/UDP/udp.server.js - About 1 hr to fix

                  Function _httpExport has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  var _httpExport = function (xMessageParam, next, end, xyz) {
    var requestConfig = xMessageParam.requestConfig;
    var responseCallback = xMessageParam.responseCallback;
    var postData = requestConfig.json;
    delete requestConfig.json;
                  Severity: Minor
                  Found in built/Transport/Middlewares/http.export.middleware.js - About 1 hr to fix

                    Function constructor has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      constructor (xyz: XYZ, port: number) {
    super()
    this.port = port
    this.xyz = xyz
                    Severity: Minor
                    Found in src/Transport/UDP/udp.server.ts - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language