Sign upLogin

noesya/osuny

View on GitHub
Star

Showing 123 of 126 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    init: function () {
        'use strict';
        var i;
        this.textareas = document.querySelectorAll('textarea[data-provider="codemirror"]');
        this.instances = [];
Severity: Major
Found in app/assets/javascripts/admin/plugins/codemirror.js and 1 other location - About 3 hrs to fix
app/assets/javascripts/admin/plugins/sortable.js on lines 8..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    init: function () {
        'use strict';
        var i;
        this.containers = document.querySelectorAll('[data-sortable]');
        this.instances = [];
Severity: Major
Found in app/assets/javascripts/admin/plugins/sortable.js and 1 other location - About 3 hrs to fix
app/assets/javascripts/admin/plugins/codemirror.js on lines 13..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function setConfigs has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    setConfigs: function () {
        'use strict';
        this.setConfig('link',
            {
                toolbar: [
Severity: Major
Found in app/assets/javascripts/application/plugins/summernote.js - About 2 hrs to fix

    Method perform has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def perform
    begin
      # Skip callbacks
      Communication::Block.skip_callback :save, :after, :touch_about
      Communication::Block.skip_callback :save, :after, :connect_and_sync_direct_sources
    Severity: Major
    Found in app/jobs/refactor_options_job.rb - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (notyfNotices.length > 0) {
        notyf.open({
            type: 'success',
            position: {
                x: 'center',
      Severity: Major
      Found in app/assets/javascripts/application/plugins/notyf.js and 1 other location - About 1 hr to fix
      app/assets/javascripts/application/plugins/notyf.js on lines 8..20

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (notyfAlerts.length > 0) {
        notyf.open({
            type: 'error',
            position: {
                x: 'center',
      Severity: Major
      Found in app/assets/javascripts/application/plugins/notyf.js and 1 other location - About 1 hr to fix
      app/assets/javascripts/application/plugins/notyf.js on lines 21..33

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method find_cohorts has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def find_cohorts
    # based on https://stackoverflow.com/questions/3579924/accepts-nested-attributes-for-with-find-or-create
    cohorts = []
    cohorts_ids = []
    self.cohorts.map do |object|
      Severity: Minor
      Found in app/models/university/person/with_education.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function initSortable has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          initSortable: function () {
        'use strict';
        var nestedSortables,
            i;
      Severity: Minor
      Found in app/assets/javascripts/admin/plugins/treeview.js - About 1 hr to fix

        Method build_person has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def build_person
      if @email.present?
        person = @university.people
                           .where(language_id: @university.default_language_id, email: @email)
                           .first_or_initialize
        Severity: Minor
        Found in app/services/importers/hash_to_person.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (i = 0; i < this.languagesCheckboxes.length; i += 1) {
            this.languagesCheckboxes[i].addEventListener('change', this.onChangeCheckbox.bind(this));
        }
          Severity: Major
          Found in app/assets/javascripts/admin/commons/default_language_selector.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/admin/commons/batch_selectable.js on lines 19..21

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method import_blocks has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def import_blocks
    heading = nil
    blocks.each do |b|
      migration_identifier = b[:migration_identifier]
      template_kind = b[:template_kind]
          Severity: Minor
          Found in app/services/importers/api/osuny/communication/website/base.rb - About 1 hr to fix

            Method clean_html has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def self.clean_html(html)
      # invalid byte sequence in UTF-8
      # https://stackoverflow.com/questions/32826781/invalid-byte-sequence-in-utf-8-when-sanitizing-wordpress-export-content
      html = html.force_encoding('UTF-8').scrub
      # Relaxed config : https://github.com/rgrove/sanitize/blob/main/lib/sanitize/config/relaxed.rb
            Severity: Minor
            Found in app/services/importers/cleaner.rb - About 1 hr to fix

              Method reorder has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def reorder
    ids = params[:ids] || []
    first_object = model.find_by(id: ids.first)
    ids.each.with_index do |id, index|
      object = model.find_by(id: id)
              Severity: Minor
              Found in app/controllers/concerns/admin/reorderable.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function sanitizeElementAttributes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  sanitizeElementAttributes: function (elmt, allowedAttributes) {
        'use strict';
        var children = elmt.children,
            child,
            i,
              Severity: Minor
              Found in app/assets/javascripts/application/plugins/summernote.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method send_confirmation_instructions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  def self.send_confirmation_instructions(attributes = {})
      confirmable = find_by_unconfirmed_email_with_errors(attributes) if reconfirmable
      unless confirmable.try(:persisted?)
        confirmable = find_or_initialize_with_errors(confirmation_keys, attributes, :not_found)
      end
              Severity: Minor
              Found in app/models/user/with_authentication.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method file_validation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def file_validation
    if file.attached?
      unless file.blob.content_type == 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet'
        file.purge if persisted?
        errors.add(:file, :incorrect_type)
              Severity: Minor
              Found in app/models/import.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method add has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def add(scope_name, choices, label, multiple = false, tree = false)
              Severity: Minor
              Found in app/services/filters/base.rb - About 35 mins to fix

                Method create_missing_special_pages has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  def create_missing_special_pages
    Communication::Website::Page::TYPES.each do |page_class|
      # Special pages have a before_validation (:on_create) callback to preset title, slug, ...
      page = page_class.where(website: self, university: university, language_id: default_language_id).first_or_initialize
      next if page.persisted? # No resave
                Severity: Minor
                Found in app/models/communication/website/with_special_pages.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method clean_path has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  def self.clean_path(path)
    clean_path = path.dup
    # Remove eventual host
    clean_path = URI(clean_path).path
    # Leading slash for absolute path
                Severity: Minor
                Found in app/models/communication/website/permalink.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method from_omniauth has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def self.from_omniauth(context, attributes)
      mapping = context.sso_mapping || []
      university = context.is_a?(University) ? context : context.university

      # first step: we find the email (we are supposed to have an email mapping)
                Severity: Minor
                Found in app/models/user/with_omniauth.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language