Sign upLogin

noesya/osuny

View on GitHub
Star

Showing 45 of 63 total issues

Method render_select_filter has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def render_select_filter(f, name, value, options)
    options[:multiple] ||= false
    options[:collection] = options[:collection].map { |elmt| 
      if elmt.is_a?(String)
        [elmt, elmt]
Severity: Minor
Found in app/helpers/admin/filters_helper.rb - About 1 hr to fix

    Method clean_html has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.clean_html(html)
          # invalid byte sequence in UTF-8
          # https://stackoverflow.com/questions/32826781/invalid-byte-sequence-in-utf-8-when-sanitizing-wordpress-export-content
          html = html.force_encoding('UTF-8').scrub
          # Relaxed config : https://github.com/rgrove/sanitize/blob/main/lib/sanitize/config/relaxed.rb
    Severity: Minor
    Found in app/services/importers/cleaner.rb - About 1 hr to fix

      Method organization has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def organization
            unless @organization
              if @siren.present? && @nic.present?
                @organization = find_organization_with_siren_and_nic
              elsif @siren.present?
      Severity: Minor
      Found in app/services/importers/hash_to_organization.rb - About 55 mins to fix

      Method send_confirmation_instructions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.send_confirmation_instructions(attributes = {})
            confirmable = find_by_unconfirmed_email_with_errors(attributes) if reconfirmable
            unless confirmable.try(:persisted?)
              confirmable = find_or_initialize_with_errors(confirmation_keys, attributes, :not_found)
            end
      Severity: Minor
      Found in app/models/user/with_authentication.rb - About 55 mins to fix

      Function sanitizeElementAttributes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          sanitizeElementAttributes: function (elmt, allowedAttributes) {
              'use strict';
              var children = elmt.children,
                  child,
                  i,
      Severity: Minor
      Found in app/assets/javascripts/application/plugins/summernote.js - About 55 mins to fix

      Method file_validation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def file_validation
          if file.attached?
            unless file.blob.content_type == 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet'
              file.purge if persisted?
              errors.add(:file, :incorrect_type)
      Severity: Minor
      Found in app/models/import.rb - About 45 mins to fix

      Method publish_batch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def publish_batch
          ids = params[:ids] || []
          target_posts = @website.posts.where(id: ids)
          is_published = params[:published] == "true"
          target_posts.each do |post|
      Severity: Minor
      Found in app/controllers/admin/communication/websites/posts_controller.rb - About 45 mins to fix

      Method render_radio_buttons_filter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def render_radio_buttons_filter(f, name, value, options)
          options[:collection] = options[:collection].map { |elmt| elmt.is_a?(String) ? [elmt, elmt] : [elmt.is_a?(Hash) ? elmt[:to_s] : elmt.to_s, elmt[:id]] }
       
          f.input name, 
                  as: :radio_buttons,
      Severity: Minor
      Found in app/helpers/admin/filters_helper.rb - About 35 mins to fix

      Method osuny_collection_recursive has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def osuny_collection_recursive(list, level, localized, label_method)
          collection = []
          list.ordered(current_language).each do |object|
            object_for_name = localized ? object.best_localization_for(current_language) : object
            name = label_method.respond_to?(:call) ? label_method.call(object_for_name)
      Severity: Minor
      Found in app/helpers/admin/osuny_helper.rb - About 35 mins to fix

      Method hugo_ancestors_for_special_page has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def hugo_ancestors_for_special_page(website)
          return [] if is_a?(Communication::Website::Page::Localization)
          permalink = Communication::Website::Permalink.for_object(self, website)
          return [] unless permalink
          special_page = permalink.special_page(website)
      Severity: Minor
      Found in app/models/research/publication.rb - About 35 mins to fix

      Method render_check_boxes_filter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def render_check_boxes_filter(f, name, value, options)
          options[:collection] = options[:collection].map { |elmt| elmt.is_a?(String) ? [elmt, elmt] : [elmt.is_a?(Hash) ? elmt[:to_s] : elmt.to_s, elmt[:id]] }
          
          f.input name, 
                  as: :check_boxes,
      Severity: Minor
      Found in app/helpers/admin/filters_helper.rb - About 35 mins to fix

      Method hugo_ancestors_for_special_page has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def hugo_ancestors_for_special_page(website)
          # Si on est sur une page, pas d'ancêtres à chercher, le breadcrumb va se construire avec les parents.
          return [] if is_a?(Communication::Website::Page::Localization)
          # Sinon, les objets ont une "page spéciale", (agenda, actualités, offre de formation...)
          permalink = Communication::Website::Permalink.for_object(self, website)
      Severity: Minor
      Found in app/models/concerns/staticable.rb - About 35 mins to fix

      Method from_omniauth has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.from_omniauth(context, attributes)
            mapping = context.sso_mapping || []
            university = context.is_a?(University) ? context : context.university
       
            # first step: we find the email (we are supposed to have an email mapping)
      Severity: Minor
      Found in app/models/user/with_omniauth.rb - About 35 mins to fix

      Method recursive_dependencies_add has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def recursive_dependencies_add(array, dependency, syncable_only, follow_direct)
          # Si l'objet ne doit pas être ajouté on n'ajoute pas non plus ses dépendances récursives
          # C'est le fait de couper ici qui évite la boucle infinie
          return array unless dependency_should_be_added?(array, dependency, syncable_only)
          array << dependency if dependency.is_a?(ActiveRecord::Base)
      Severity: Minor
      Found in app/models/concerns/with_dependencies.rb - About 35 mins to fix

      Method extranet_access has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def extranet_access
            unless user_can_access_registration_context?
              extranet_l10n = registration_context.original_localization
              if extranet_l10n.registration_contact.present?
                errors.add :email, I18n.t('extranet.errors.email_not_allowed_with_contact', contact: extranet_l10n.registration_contact)
      Severity: Minor
      Found in app/models/user/with_registration_context.rb - About 35 mins to fix

      Method clean_path has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.clean_path(path)
          clean_path = path.dup
          # Remove eventual host
          clean_path = URI(clean_path).path
          # Leading slash for absolute path
      Severity: Minor
      Found in app/models/communication/website/permalink.rb - About 35 mins to fix

      Method adjust_mobile_phone has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def adjust_mobile_phone
            return if self.mobile_phone.nil?
            self.mobile_phone = self.mobile_phone.delete(' ')
            if self.mobile_phone.start_with?('06', '07')
              self.mobile_phone = "+33#{self.mobile_phone[1..-1]}"
      Severity: Minor
      Found in app/models/user/with_authentication.rb - About 25 mins to fix

      Method find_cohorts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def find_cohorts
          # based on https://stackoverflow.com/questions/3579924/accepts-nested-attributes-for-with-find-or-create
          cohorts_to_set = []
          cohorts_ids_to_set = []
          undestroyed_cohorts = self.cohorts.reject(&:_destroy)
      Severity: Minor
      Found in app/models/university/person/with_alumnus.rb - About 25 mins to fix

      Method breadcrumb has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def breadcrumb
          super
          add_breadcrumb Education::Program.model_name.human(count: 2), admin_education_programs_path
          @program.ancestors_and_self.each do |program|
            next unless program.persisted?
      Severity: Minor
      Found in app/controllers/admin/education/programs/application_controller.rb - About 25 mins to fix

      Method unpublished_by_last_save? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def unpublished_by_last_save?
          return unless respond_to?(:published)
          return true if saved_change_to_published? && !published?
          if respond_to?(:published_at)
            return saved_change_to_published_at? && (published_at.nil? || published_at > Time.now)
      Severity: Minor
      Found in app/models/concerns/with_dependencies.rb - About 25 mins to fix
      Severity
      Category
      Status
      Source
      Language