Sign upLogin

nokia/gitcache-ssh

View on GitHub
Star

Showing 4 of 4 total issues

Function main has 74 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func main() {
    log.WithFields(log.Fields{
        "version": Version,
        "build":   Build,
    }).Debugf("Starting %s", logIdentity)
Severity: Minor
Found in gitcache-ssh.go - About 1 hr to fix

    Function main has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
    Open

    func main() {
    log.WithFields(log.Fields{
        "version": Version,
        "build":   Build,
    }).Debugf("Starting %s", logIdentity)
    Severity: Minor
    Found in gitcache-ssh.go - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Your code does not pass gofmt in 3 places. Go fmt your code!
    Open

    // Git wrapper for use on a local gitlab-cache machine.
    Severity: Minor
    Found in gitcache-ssh.go by gofmt

    2: cannot find package "github.com/mattn/go-shellwords" in any of:
    Open

        shellwords "github.com/mattn/go-shellwords"
    Severity: Minor
    Found in gitcache-ssh.go by govet
    Severity
    Category
    Status
    Source
    Language