Sign upLogin

noodlefrenzy/node-amqp10

View on GitHub
Star
lib/amqp_client.js

Summary

Maintainability
D
2 days
Test Coverage

File amqp_client.js has 357 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';
var EventEmitter = require('events').EventEmitter,
    Promise = require('bluebird'),
    debug = require('debug')('amqp10:client'),
    util = require('util'),
Severity: Minor
Found in lib/amqp_client.js - About 4 hrs to fix

    Function connect has 100 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    AMQPClient.prototype.connect = function(url, policyOverrides) {
  var self = this;
  policyOverrides = policyOverrides || {};
  var connectPolicy = u.deepMerge(policyOverrides, self.policy.connect);
  return new Promise(function(resolve, reject) {
    Severity: Major
    Found in lib/amqp_client.js - About 4 hrs to fix

      Function createReceiver has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      AMQPClient.prototype.createReceiver = function(address, policyOverrides, session) {
  if (!this._connection) {
    throw new Error('Must connect before creating links');
  }
      Severity: Minor
      Found in lib/amqp_client.js - About 1 hr to fix

        Function createSender has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        AMQPClient.prototype.createSender = function(address, policyOverrides, session) {
  if (!this._connection) {
    throw new Error('Must connect before creating links');
  }
        Severity: Minor
        Found in lib/amqp_client.js - About 1 hr to fix

          Function _getSession has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          AMQPClient.prototype._getSession = function(session) {
  // Just return the provided session if one was passed in
  if (session) {
    return Promise.resolve(session);
  }
          Severity: Minor
          Found in lib/amqp_client.js - About 1 hr to fix

            Function AMQPClient has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function AMQPClient(policy, policyOverrides) {
  if (!(policy instanceof Policy)) {
    this.policy = pu.Merge(policy, new Policy());
  } else {
    this.policy = policy || new Policy();
            Severity: Minor
            Found in lib/amqp_client.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function createSender has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            AMQPClient.prototype.createSender = function(address, policyOverrides, session) {
  if (!this._connection) {
    throw new Error('Must connect before creating links');
  }
            Severity: Minor
            Found in lib/amqp_client.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function createReceiver has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            AMQPClient.prototype.createReceiver = function(address, policyOverrides, session) {
  if (!this._connection) {
    throw new Error('Must connect before creating links');
  }
            Severity: Minor
            Found in lib/amqp_client.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _getSession has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            AMQPClient.prototype._getSession = function(session) {
  // Just return the provided session if one was passed in
  if (session) {
    return Promise.resolve(session);
  }
            Severity: Minor
            Found in lib/amqp_client.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              return this._getSession(session).then(function (session) {
    return new Promise(function(resolve, reject) {
      var attach = function() {
        var attachPromise = function(_err, _link) {
          if (!!_err) return reject(_err);
            Severity: Major
            Found in lib/amqp_client.js and 1 other location - About 4 hrs to fix
            lib/amqp_client.js on lines 384..398

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 123.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              return this._getSession(session).then(function (session) {
    return new Promise(function(resolve, reject) {
      var attach = function() {
        var attachPromise = function(_err, _link) {
          if (!!_err) return reject(_err);
            Severity: Major
            Found in lib/amqp_client.js and 1 other location - About 4 hrs to fix
            lib/amqp_client.js on lines 308..322

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 123.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              session.on(Session.ErrorReceived, function(e) {
    debug('session error: ', e);
    self.emit(AMQPClient.ErrorReceived, e);
  });
            Severity: Minor
            Found in lib/amqp_client.js and 1 other location - About 35 mins to fix
            lib/amqp_client.js on lines 531..534

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              connection.on(Connection.ErrorReceived, function(e) {
    debug('connection error: ', e);
    self.emit(AMQPClient.ErrorReceived, e);
  });
            Severity: Minor
            Found in lib/amqp_client.js and 1 other location - About 35 mins to fix
            lib/amqp_client.js on lines 551..554

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status