nopolabs/yabot

Client has 32 functions (exceeds 20 allowed). Consider refactoring.

Open

class Client
{
    use ConfigTrait;
    use LogTrait;

The class Client has 15 public methods. Consider refactoring Client to keep number of public methods under 10.

Open

class Client
{
    use ConfigTrait;
    use LogTrait;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

        string $name,
        $isBot,
        array $channels,
        array $users,
        array $patterns,

Avoid variables with short names like $id. Configured minimum length is 3.

Open

    public function byId($id)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

        LoggerInterface $logger,
        LoopInterface $eventLoop,
        Client $slackClient,
        MessageFactory $messageFactory,
        PluginManager $pluginManager,

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

        RealTimeClient $realTimeClient,
        Users $users,
        Bots $bots,
        Channels $channels,
        array $config = [],

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

        string $pluginId,
        bool $isBot = null,
        array $channels,
        array $users,
        LoggerInterface $logger = null)

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

        Client $slackClient,
        array $data,
        string $formattedText,
        User $user = null,
        Channel $channel)

Expected 1 space after FUNCTION keyword; 0 found

Open

        $onRejected = $onRejected ?? function($reason) { $this->logRejection($reason); };

• Exclude checks
  • Disable engine
  • Disable check

There must be one blank line after the namespace declaration

Open

namespace Nopolabs\Yabot\Slack;

• Exclude checks
  • Disable engine
  • Disable check

There must be one blank line after the namespace declaration

Open

namespace Nopolabs\Yabot\Guzzle;

• Exclude checks
  • Disable engine
  • Disable check

There must be one blank line after the namespace declaration

Open

namespace Nopolabs\Yabot\Slack;

• Exclude checks
  • Disable engine
  • Disable check

The closing parenthesis of a multi-line function declaration must be on a new line

Open

        LoggerInterface $log = null)

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after FUNCTION keyword; 0 found

Open

            $params['patterns'] = array_map(function($pattern) use ($search, $replace) {

• Exclude checks
  • Disable engine
  • Disable check

There must be one blank line after the namespace declaration

Open

namespace Nopolabs\Yabot\Slack;

• Exclude checks
  • Disable engine
  • Disable check

Each PHP statement must be on a line by itself

Open

        $onRejected = $onRejected ?? function($reason) { $this->logRejection($reason); };

• Exclude checks
  • Disable engine
  • Disable check

Blank line found at start of control structure

Open

        if ($interval = $this->get('connection_monitor.interval')) {

• Exclude checks
  • Disable engine
  • Disable check

There must be one blank line after the namespace declaration

Open

namespace Nopolabs\Yabot\Plugin;

• Exclude checks
  • Disable engine
  • Disable check

There must be one blank line after the namespace declaration

Open

namespace Nopolabs\Yabot\Helpers;

• Exclude checks
  • Disable engine
  • Disable check

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line

Open

    {

• Exclude checks
  • Disable engine
  • Disable check