nordsoftware/lumen-file-manager

View on GitHub

Showing 14 of 14 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php namespace Nord\Lumen\FileManager\Doctrine\ORM;

use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\EntityRepository;
use Nord\Lumen\FileManager\Contracts\File as FileContract;
Severity: Major
Found in src/Doctrine/ORM/FileStorage.php and 1 other location - About 6 hrs to fix
src/Doctrine/ODM/FileStorage.php on lines 1..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 206.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php namespace Nord\Lumen\FileManager\Doctrine\ODM;

use Doctrine\ODM\MongoDB\DocumentManager;
use Doctrine\ODM\MongoDB\DocumentRepository;
use Nord\Lumen\FileManager\Contracts\File as FileContract;
Severity: Major
Found in src/Doctrine/ODM/FileStorage.php and 1 other location - About 6 hrs to fix
src/Doctrine/ORM/FileStorage.php on lines 1..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 206.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class File implements FileContract
{
    /**
     * @ORM\Id
     * @ORM\GeneratedValue
Severity: Minor
Found in src/Doctrine/ORM/File.php - About 2 hrs to fix

    File has 25 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class File implements FileContract
    {
    
        /**
         * @var \MongoId
    Severity: Minor
    Found in src/Doctrine/ODM/File.php - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function __construct(
              $id,
              $name,
              $extension,
              $path,
      Severity: Major
      Found in src/Doctrine/ORM/File.php and 1 other location - About 2 hrs to fix
      src/Doctrine/ODM/File.php on lines 75..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function __construct(
              $id,
              $name,
              $extension,
              $path,
      Severity: Major
      Found in src/Doctrine/ODM/File.php and 1 other location - About 2 hrs to fix
      src/Doctrine/ORM/File.php on lines 78..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php namespace Nord\Lumen\FileManager\Doctrine\ODM;
      
      use Doctrine\ODM\MongoDB\DocumentManager;
      use Illuminate\Contracts\Container\Container;
      use Illuminate\Support\ServiceProvider;
      Severity: Major
      Found in src/Doctrine/ODM/DoctrineServiceProvider.php and 1 other location - About 1 hr to fix
      src/Doctrine/ORM/DoctrineServiceProvider.php on lines 1..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php namespace Nord\Lumen\FileManager\Doctrine\ORM;
      
      use Doctrine\ORM\EntityManagerInterface;
      use Illuminate\Contracts\Container\Container;
      use Illuminate\Support\ServiceProvider;
      Severity: Major
      Found in src/Doctrine/ORM/DoctrineServiceProvider.php and 1 other location - About 1 hr to fix
      src/Doctrine/ODM/DoctrineServiceProvider.php on lines 1..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method saveFile has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function saveFile(FileInfo $info, array $options = [])
          {
              if (!isset($options['name'])) {
                  $filename        = $this->getFilenameFromFileInfo($info);
                  $options['name'] = substr($filename, 0, (strrpos($filename, '.')));
      Severity: Minor
      Found in src/FileManager.php - About 1 hr to fix

        Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $id,
                $name,
                $extension,
                $path,
                $mimeType,
        Severity: Major
        Found in src/Doctrine/ORM/File.php - About 1 hr to fix

          Method createFile has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function createFile($id, $name, $extension, $path, $mimeType, $byteSize, $data, $disk, Carbon $savedAt)
          Severity: Major
          Found in src/Eloquent/FileFactory.php - About 1 hr to fix

            Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $id,
                    $name,
                    $extension,
                    $path,
                    $mimeType,
            Severity: Major
            Found in src/Doctrine/ODM/File.php - About 1 hr to fix

              Method createFile has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function createFile($id, $name, $extension, $path, $mimeType, $byteSize, $data, $disk, Carbon $savedAt)
              Severity: Major
              Found in src/Doctrine/FileFactory.php - About 1 hr to fix

                Method createFile has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function createFile($id, $name, $extension, $path, $mimeType, $byteSize, $data, $disk, Carbon $savedAt);
                Severity: Major
                Found in src/Contracts/FileFactory.php - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language