Sign upLogin

notduncansmith/summit

View on GitHub
Star

Showing 96 of 96 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  return this.view('byTwitterId', params, opts || {})
  .then(function (results) {
    if (results.length === 0) {
      return false;
    }
Severity: Major
Found in lib/collection/user.js and 2 other locations - About 1 hr to fix
lib/collection/user.js on lines 74..85
lib/collection/user.js on lines 127..138

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  return this.view('byEmail', params, opts || {})
  .then(function (results) {
    if (results.length === 0) {
      return false;
    }
Severity: Major
Found in lib/collection/user.js and 2 other locations - About 1 hr to fix
lib/collection/user.js on lines 101..112
lib/collection/user.js on lines 127..138

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  return this.view('byFacebookId', params, opts || {})
  .then(function (results) {
    if (results.length === 0) {
      return false;
    }
Severity: Major
Found in lib/collection/user.js and 2 other locations - About 1 hr to fix
lib/collection/user.js on lines 74..85
lib/collection/user.js on lines 101..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function contains has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

GroupCollection.prototype.contains = function (id, opts) {
  var keys = _.isArray(id) ? id : [id]
    , self = this
    , view = (opts && opts.view) ? opts.view : 'contains'; // Allow the user to override the view used
Severity: Minor
Found in lib/collection/group.js - About 1 hr to fix

    Function errorResponse has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    function errorResponse(config, req, err) {
  var message = '<h3>Message:</h3>';

  if (config.showError) {
    if (typeof err === 'string') {
    Severity: Minor
    Found in lib/middleware/error_middleware.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function exports has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function (db) {
  return function search (opts) {
    var opts = _.extend({}, {include_docs: true}, opts || {});

    if (!opts.filter && opts.collection) {
    Severity: Minor
    Found in lib/drivers/search/pouch.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validate has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    UserCollection.prototype.validate = function (user) {
  var services = ['password', 'facebook', 'twitter']
    , identifiers = ['email', 'facebookId', 'twitterId', 'username']
    , userIdentifiers = [];
    Severity: Minor
    Found in lib/collection/user.js - About 1 hr to fix

      Function exports has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function (app) {
  return app.collection({
    name: 'Page',
    isPostType: true,
    timestamps: true,
      Severity: Minor
      Found in cms/page.js - About 1 hr to fix

        Function bogartHandlebarsCallback has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          var callback = function bogartHandlebarsCallback(app, injector, next) {
    var localsDefaults = {};

    return Promise.all(loadViews)
    .then(function (viewMapArray) {
        Severity: Minor
        Found in lib/middleware/handlebars_middleware.js - About 1 hr to fix

          Function exports has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function (db) {
  return function search (opts) {
    var opts = _.extend({}, {include_docs: true}, opts || {});

    if (!opts.filter && opts.collection) {
          Severity: Minor
          Found in lib/drivers/search/pouch.js - About 1 hr to fix

            Function search has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              return function search (opts) {
    var opts = _.extend({}, {include_docs: true}, opts || {});

    if (!opts.filter && opts.collection) {
      if (typeof opts.collection === 'string') {
            Severity: Minor
            Found in lib/drivers/search/pouch.js - About 1 hr to fix

              Function setup has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              Collection.prototype.setup = function () {
  var doc = helpers.designDoc(this);
  var self = this;
  var ensureStaticDocs = [];
              Severity: Minor
              Found in lib/collection.js - About 1 hr to fix

                Function search has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                Collection.prototype.search = function (opts, filtered) {
  /*
    Only supports ElasticSearch since
    that's what apps currently in
    production were using before the
                Severity: Minor
                Found in lib/collection.js - About 1 hr to fix

                  Function facebook has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function facebook (app) {
  var router = app.router(false);

  router.get('/facebook/login', function facebookLogin (req, next) {
                  Severity: Minor
                  Found in lib/middleware/facebook_middleware.js - About 1 hr to fix

                    Function getInput has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function getInput (name, type) {
  var base = '<div class="form-group">'
    , $ = cheerio.load(base);

  switch (type) {
                    Severity: Minor
                    Found in lib/collection/forms.js - About 1 hr to fix

                      Function errorResponse has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function errorResponse(config, req, err) {
  var message = '<h3>Message:</h3>';

  if (config.showError) {
    if (typeof err === 'string') {
                      Severity: Minor
                      Found in lib/middleware/error_middleware.js - About 1 hr to fix

                        Function makeApiRoutes has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function makeApiRoutes (collection) {
  // Get a router
  var router = collection.router;
  var name = inflection.dasherize(collection.name.toLowerCase());
                        Severity: Minor
                        Found in lib/collection/collection_routes.js - About 1 hr to fix

                          Function exports has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          module.exports = function () {
  var helpers = [
      'res'
    , 'file'
    , 'text'
                          Severity: Minor
                          Found in lib/summit.js - About 1 hr to fix

                            Function attachments has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            module.exports = function attachments (app) {
  var router = app.router(false);

  router.get('/attachment/:docId/:attId', function (req) {
    var att;
                            Severity: Minor
                            Found in lib/middleware/attachments_middleware.js - About 1 hr to fix

                              Function put has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                              Database.prototype.put = function (name, doc, force) {
  var args = []
    , self = this;

  if (force && force === true) {
                              Severity: Minor
                              Found in lib/drivers/database/nano.js - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language