Sign upLogin

noushmac/ngx-magic-table

View on GitHub
Star

Showing 23 of 47 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export class NgxBooleanFilterComponent implements OnInit {
  @Input() rows: any[];
  @Input() cell: HeaderCell;
  @Input() items: any[];
Severity: Major
Found in projects/ngx-magic-table/src/lib/ngx-boolean-filter/ngx-boolean-filter.component.ts and 1 other location - About 1 day to fix
projects/ngx-magic-table/src/lib/ngx-enum-filter/ngx-enum-filter.component.ts on lines 9..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 334.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export class NgxEnumFilterComponent implements OnInit {
  @Input() rows: any[];
  @Input() cell: HeaderCell;
  @Input() items: any[];
Severity: Major
Found in projects/ngx-magic-table/src/lib/ngx-enum-filter/ngx-enum-filter.component.ts and 1 other location - About 1 day to fix
projects/ngx-magic-table/src/lib/ngx-boolean-filter/ngx-boolean-filter.component.ts on lines 9..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 334.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export class NgxStringFilterComponent implements OnInit {
  @Input() rows: any[];
  @Input() cell: HeaderCell;

  @Output() filterChange= new EventEmitter();
Severity: Major
Found in projects/ngx-magic-table/src/lib/ngx-string-filter/ngx-string-filter.component.ts and 1 other location - About 1 day to fix
projects/ngx-magic-table/src/lib/ngx-numeric-filter/ngx-numeric-filter.component.ts on lines 9..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 318.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export class NgxNumericFilterComponent implements OnInit {
  @Input() rows: any[];
  @Input() cell: HeaderCell;

  @Output() filterChange = new EventEmitter();
Severity: Major
Found in projects/ngx-magic-table/src/lib/ngx-numeric-filter/ngx-numeric-filter.component.ts and 1 other location - About 1 day to fix
projects/ngx-magic-table/src/lib/ngx-string-filter/ngx-string-filter.component.ts on lines 9..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 318.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File ngx-magic-table.component.ts has 698 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { element } from "protractor";
import { PagingInput } from "../models/Paging-input";
import { SortInput } from "../models/sort-input";
import {
  Component,
Severity: Major
Found in projects/ngx-magic-table/src/lib/ngx-magic-table/ngx-magic-table.component.ts - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    module.exports = function (config) {
  config.set({
    basePath: '',
    frameworks: ['jasmine', '@angular-devkit/build-angular'],
    plugins: [
    Severity: Major
    Found in src/karma.conf.js and 1 other location - About 6 hrs to fix
    projects/ngx-magic-table/karma.conf.js on lines 4..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 170.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function onLoadTable has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

      onLoadTable() {
    if (this.templatesArrayBase != null) {
      for (let index = 0; index < this.templatesArrayBase.length; index++) {
        const element = this.templatesArrayBase[index];
        this.templatesArray[index].index = element.index;
    Severity: Minor
    Found in projects/ngx-magic-table/src/lib/ngx-magic-table/ngx-magic-table.component.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          } else {
        rows.sort((a: any, b: any) => {
          if (a[field] > b[field]) {
            return -1;
          } else if (a[field] < b[field]) {
    Severity: Major
    Found in projects/ngx-magic-table/src/lib/sort/sort.pipe.ts and 1 other location - About 2 hrs to fix
    projects/ngx-magic-table/src/lib/sort/sort.pipe.ts on lines 17..27

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          if (direction === OrderDirection.Ascending) {
        rows.sort((a: any, b: any) => {
          if (a[field] < b[field]) {
            return -1;
          } else if (a[field] > b[field]) {
    Severity: Major
    Found in projects/ngx-magic-table/src/lib/sort/sort.pipe.ts and 1 other location - About 2 hrs to fix
    projects/ngx-magic-table/src/lib/sort/sort.pipe.ts on lines 27..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function transform has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      transform(rows: any[], args: any): any[] {
    const field = args.field;
    const active = args.active || true;
    const direction = args.direction;
    if (rows === undefined) {
    Severity: Minor
    Found in projects/ngx-magic-table/src/lib/sort/sort.pipe.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        public doubleSelectRow(row: T) {
    this.selectedRow = row;
    this.rowSelected = row;
    this.doubleClick.emit(this.selectedRow);
  }
      Severity: Major
      Found in projects/ngx-magic-table/src/lib/ngx-magic-table/ngx-magic-table.component.ts and 1 other location - About 1 hr to fix
      projects/ngx-magic-table/src/lib/ngx-magic-table/ngx-magic-table.component.ts on lines 447..451

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        public selectRow(row: T) {
    this.selectedRow = row;
    this.rowSelected = row;
    this.selectedChange.emit(this.selectedRow);
  }
      Severity: Major
      Found in projects/ngx-magic-table/src/lib/ngx-magic-table/ngx-magic-table.component.ts and 1 other location - About 1 hr to fix
      projects/ngx-magic-table/src/lib/ngx-magic-table/ngx-magic-table.component.ts on lines 452..456

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function exports has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function (config) {
  config.set({
    basePath: '',
    frameworks: ['jasmine', '@angular-devkit/build-angular'],
    plugins: [
      Severity: Minor
      Found in src/karma.conf.js - About 1 hr to fix

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

            export function values() {
        return Object.keys(filters).filter(
        (type) => isNaN(<any>type) && type !== 'values'
        );
    }
        Severity: Major
        Found in projects/ngx-magic-table/src/lib/models/numeric-filter.ts and 3 other locations - About 45 mins to fix
        projects/ngx-magic-table/src/lib/models/boolean-filter.ts on lines 8..12
        projects/ngx-magic-table/src/lib/models/enum-filter.ts on lines 9..13
        projects/ngx-magic-table/src/lib/models/string-filter.ts on lines 16..20

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

            export function values() {
      return Object.keys(filters).filter(
        (type) => isNaN(<any>type) && type !== 'values'
      );
    }
        Severity: Major
        Found in projects/ngx-magic-table/src/lib/models/string-filter.ts and 3 other locations - About 45 mins to fix
        projects/ngx-magic-table/src/lib/models/boolean-filter.ts on lines 8..12
        projects/ngx-magic-table/src/lib/models/enum-filter.ts on lines 9..13
        projects/ngx-magic-table/src/lib/models/numeric-filter.ts on lines 12..16

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

            export function values() {
      return Object.keys(filters).filter(
        (type) => isNaN(<any>type) && type !== 'values'
      );
    }
        Severity: Major
        Found in projects/ngx-magic-table/src/lib/models/enum-filter.ts and 3 other locations - About 45 mins to fix
        projects/ngx-magic-table/src/lib/models/boolean-filter.ts on lines 8..12
        projects/ngx-magic-table/src/lib/models/numeric-filter.ts on lines 12..16
        projects/ngx-magic-table/src/lib/models/string-filter.ts on lines 16..20

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid deeply nested control flow statements.
        Open

                    if (this.autoSize) {
              this.autoSizeCells(this.mainSize());
            }
        Severity: Major
        Found in projects/ngx-magic-table/src/lib/ngx-magic-table/ngx-magic-table.component.ts - About 45 mins to fix

          Identical blocks of code found in 4 locations. Consider refactoring.
          Open

              export function values() {
      return Object.keys(filters).filter(
        (type) => isNaN(<any>type) && type !== 'values'
      );
    }
          Severity: Major
          Found in projects/ngx-magic-table/src/lib/models/boolean-filter.ts and 3 other locations - About 45 mins to fix
          projects/ngx-magic-table/src/lib/models/enum-filter.ts on lines 9..13
          projects/ngx-magic-table/src/lib/models/numeric-filter.ts on lines 12..16
          projects/ngx-magic-table/src/lib/models/string-filter.ts on lines 16..20

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      this.dropdownSettings = {
              singleSelection: false,
              idField: "item_id",
              textField: "item_text",
              selectAllText: "Select All",
          Severity: Minor
          Found in projects/ngx-magic-table/src/lib/ngx-magic-table/ngx-magic-table.component.ts and 1 other location - About 35 mins to fix
          projects/ngx-magic-table/src/lib/ngx-magic-table/ngx-magic-table.component.ts on lines 708..716

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                this.dropdownSettings = {
        singleSelection: false,
        idField: "item_id",
        textField: "item_text",
        selectAllText: "Select All",
          Severity: Minor
          Found in projects/ngx-magic-table/src/lib/ngx-magic-table/ngx-magic-table.component.ts and 1 other location - About 35 mins to fix
          projects/ngx-magic-table/src/lib/ngx-magic-table/ngx-magic-table.component.ts on lines 659..667

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language