noushmac/ngx-magic-table

View on GitHub

Showing 8 of 47 total issues

File ngx-magic-table.component.ts has 698 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { element } from "protractor";
import { PagingInput } from "../models/Paging-input";
import { SortInput } from "../models/sort-input";
import {
  Component,

    Function onLoadTable has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

      onLoadTable() {
        if (this.templatesArrayBase != null) {
          for (let index = 0; index < this.templatesArrayBase.length; index++) {
            const element = this.templatesArrayBase[index];
            this.templatesArray[index].index = element.index;

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function transform has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      transform(rows: any[], args: any): any[] {
        const field = args.field;
        const active = args.active || true;
        const direction = args.direction;
        if (rows === undefined) {
    Severity: Minor
    Found in projects/ngx-magic-table/src/lib/sort/sort.pipe.ts - About 1 hr to fix

      Function exports has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function (config) {
        config.set({
          basePath: '',
          frameworks: ['jasmine', '@angular-devkit/build-angular'],
          plugins: [
      Severity: Minor
      Found in src/karma.conf.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                    if (this.autoSize) {
                      this.autoSizeCells(this.mainSize());
                    }

          Avoid too many return statements within this function.
          Open

                return 0;

            Function sortToggle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              public sortToggle(cell: HeaderCell) {
                if (cell.sortable === false) {
                  return;
                }
            
            

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function transform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              transform(rows: any[], args: any): any[] {
                const field = args.field;
                const active = args.active || true;
                const direction = args.direction;
                if (rows === undefined) {
            Severity: Minor
            Found in projects/ngx-magic-table/src/lib/sort/sort.pipe.ts - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language