Sign upLogin

npolar/api.npolar.no

View on GitHub
Star
lib/metadata/rack/dif_jsonizer.rb

Summary

Maintainability
C
1 day
Test Coverage

Method atom_entry has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

      def atom_entry(metadata_dataset)
        dataset = dataset = Metadata::Dataset.new(metadata_dataset)
        entry = ::Atom::Entry.new do |e|
          e.id = dataset.id =~ /^\w{8}[-]\w{4}-\w{4}-\w{4}-\w{12}$/ ? "urn:uuid:#{dataset.id}" : dataset.id
Severity: Minor
Found in lib/metadata/rack/dif_jsonizer.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method xml_from_json has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

      def xml_from_json(request)

        response = app.call(request.env)

        if response.status < 300
Severity: Minor
Found in lib/metadata/rack/dif_jsonizer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method atom_entry has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def atom_entry(metadata_dataset)
        dataset = dataset = Metadata::Dataset.new(metadata_dataset)
        entry = ::Atom::Entry.new do |e|
          e.id = dataset.id =~ /^\w{8}[-]\w{4}-\w{4}-\w{4}-\w{12}$/ ? "urn:uuid:#{dataset.id}" : dataset.id
Severity: Major
Found in lib/metadata/rack/dif_jsonizer.rb - About 2 hrs to fix

    Method xml_from_json has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def xml_from_json(request)

        response = app.call(request.env)

        if response.status < 300
    Severity: Minor
    Found in lib/metadata/rack/dif_jsonizer.rb - About 1 hr to fix

      Method condition? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def condition?( request )
        # GET
        if (FORMATS.include? request.format or request.content_type =~ /application\/xml/) and "GET" == request.request_method
          true
        # POST, PUT
      Severity: Minor
      Found in lib/metadata/rack/dif_jsonizer.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def iso(dif)
        tmp = Tempfile.new('dif')
        iso = ""
        begin
          tmp.write dif
      Severity: Minor
      Found in lib/metadata/rack/dif_jsonizer.rb and 1 other location - About 45 mins to fix
      lib/npolar/rack/atomizer.rb on lines 123..136

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status