Sign upLogin

npolar/api.npolar.no

View on GitHub
Star
lib/npolar/rack/request.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method username has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def username
        
        if headers["HTTP_AUTHORIZATION"] =~ /^Bearer\s[a-zA-Z0-9_-]+\.[a-zA-Z0-9_-]+\.[a-zA-Z0-9_-]+/
         
          payload = headers["HTTP_AUTHORIZATION"].split("Bearer ")[1].split(".")[1]
Severity: Minor
Found in lib/npolar/rack/request.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method accept_format has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def accept_format
        return "" if env['HTTP_ACCEPT'].nil?
  
        format = env['HTTP_ACCEPT'].scan(/[^;,\s]*\/[^;,\s]*/)[0].split("/")[1]
Severity: Minor
Found in lib/npolar/rack/request.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method id has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def id
  
        id = path_info.split("/")[1]

        # Fix for /path/id.with.dot like /person/full.name - where format is "json" (derived from either Accept or Content-Type)
Severity: Minor
Found in lib/npolar/rack/request.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method format has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def format
   
        # If &format= is present we let that win
        if params.size > 0 and params.key?("format")
          format = params["format"]
Severity: Minor
Found in lib/npolar/rack/request.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status