Sign upLogin

npolar/api.npolar.no

View on GitHub
Star
migration/publication/publication_migration0.rb

Summary

Maintainability
D
1 day
Test Coverage

Method locations_as_object has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def locations_as_object
    lambda {|d|

      if d.locations? and d.locations.any? and d.locations.all? {|l| l.is_a? String }
        log.info d.title.to_json
Severity: Minor
Found in migration/publication/publication_migration0.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method location_fixer has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def location_fixer(locations)
    fixed = []

    fixed += locations.select {|l| l=~ /Svalbard/ui }.map {|l|
      placename = l.split("-").last.strip
Severity: Major
Found in migration/publication/publication_migration0.rb - About 2 hrs to fix

    Method fix_conference_dates has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def fix_conference_dates
    lambda {|d|
      if d.conference? and d.conference.dates? and d.conference.dates.any?
         d.conference.dates.each_with_index do |dt,idx|
    Severity: Minor
    Found in migration/publication/publication_migration0.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method locations_as_object has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def locations_as_object
    lambda {|d|

      if d.locations? and d.locations.any? and d.locations.all? {|l| l.is_a? String }
        log.info d.title.to_json
    Severity: Minor
    Found in migration/publication/publication_migration0.rb - About 1 hr to fix

      Method force_country has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def force_country
    lambda {|d|
     if d.locations? and d.locations.any?
        d.locations.each do |l|
          if l.country.nil? or l.country.to_s == ""
      Severity: Minor
      Found in migration/publication/publication_migration0.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method simple_fixes has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def simple_fixes
    lambda {|d|
      
      d.schema = "http://api.npolar.no/schema/publication-1.0-rc4"
      unless d.publication_lang?
      Severity: Minor
      Found in migration/publication/publication_migration0.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method fix_invalid_links has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def fix_invalid_links
    @@broken=[]
    lambda {|d|

      if d.links? and d.links.any?
      Severity: Minor
      Found in migration/publication/publication_migration0.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method location_fixer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def location_fixer(locations)
    fixed = []

    fixed += locations.select {|l| l=~ /Svalbard/ui }.map {|l|
      placename = l.split("-").last.strip
      Severity: Minor
      Found in migration/publication/publication_migration0.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          fixed += locations.select {|l| l=~ /Dronning Maud Land/ui }.map {|l|
      placename = l.split("-").last.strip
      { area: "Dronning Maud Land", country: "AQ", placename: placename, hemisphere: "S" }
    }
      Severity: Minor
      Found in migration/publication/publication_migration0.rb and 3 other locations - About 25 mins to fix
      migration/publication/publication_migration0.rb on lines 223..227
      migration/publication/publication_migration0.rb on lines 228..233
      migration/publication/publication_migration0.rb on lines 234..239

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          fixed += locations.select {|l| l=~ /Svalbard/ui }.map {|l|
      placename = l.split("-").last.strip   
      { area: "Svalbard", country: "NO", placename: placename, hemisphere: "N"  }
    }
      Severity: Minor
      Found in migration/publication/publication_migration0.rb and 3 other locations - About 25 mins to fix
      migration/publication/publication_migration0.rb on lines 228..233
      migration/publication/publication_migration0.rb on lines 234..239
      migration/publication/publication_migration0.rb on lines 264..268

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          fixed += locations.select {|l| l=~ /Jan Mayen/ui }.map {|l|
      placename = l.split("-").last.strip
      # Jan Mayen: http://placenames.npolar.no/stadnamn/Jan+Mayen?ident=18491 70.98455 -8.477247
      { area: "Jan Mayen", country: "NO", placename: placename , hemisphere: "N" }
    }
      Severity: Minor
      Found in migration/publication/publication_migration0.rb and 3 other locations - About 25 mins to fix
      migration/publication/publication_migration0.rb on lines 223..227
      migration/publication/publication_migration0.rb on lines 228..233
      migration/publication/publication_migration0.rb on lines 264..268

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          fixed += locations.select {|l| l=~ /Bjørnøya/ui }.map {|l|
      placename = l.split("-").last.strip
      # Bjørnøya: http://placenames.npolar.no/stadnamn/Bj%C3%B8rn%C3%B8ya?ident=1221 74.38743 18.978537
      { area: "Svalbard", country: "NO", placename: placename,  hemisphere: "N"  }
    }
      Severity: Minor
      Found in migration/publication/publication_migration0.rb and 3 other locations - About 25 mins to fix
      migration/publication/publication_migration0.rb on lines 223..227
      migration/publication/publication_migration0.rb on lines 234..239
      migration/publication/publication_migration0.rb on lines 264..268

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status