Sign upLogin

npolar/argos-ruby

View on GitHub
Star

Showing 31 of 31 total issues

Method _call_xml_operation has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def _call_xml_operation(op_sym, body, extract=nil)
      @operation = _operation(op_sym)
      @operation.body = body
      @response = operation.call
Severity: Minor
Found in lib/argos/soap.rb - About 1 hr to fix

    Method baseRequest has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def baseRequest
      # if override key is platformId... delete programNumber...
      # if override key is period... delete nbDaysFromNow...
      baseRequest = { username: _username, password: _password }
    Severity: Minor
    Found in lib/argos/soap.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method sensor_data= has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def sensor_data=(sensor_data)
      
      # Hex string?
      if sensor_data.is_a? String
        bytes = (sensor_data.size/2)
    Severity: Minor
    Found in lib/argos/sensor_data.rb - About 1 hr to fix

      Method download has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def self.download(username, password, archive, log, days=20)
      Severity: Minor
      Found in lib/argos/download.rb - About 35 mins to fix

        Method source has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def self.source(argos)
  
      argos.parse(argos.filename)
  
      latitude_mean = longitude_mean = nil
        Severity: Minor
        Found in lib/argos/ascii.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method output has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def output
      
      if debug?
        log.debug "#{CMD} param: #{param.to_json}"
        unless soap.request.nil?
        Severity: Minor
        Found in lib/argos/soap_command.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method unfold has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def unfold

      # First, grab all segments *without* measurements (if any)
      unfolded = messages.reject {|ds| ds.key?(:measurements) or ds[:measurements].nil? }.map {|m| m[:cardinality] = 0 }
      log.debug "#{messages.size - unfolded.size} / #{messages.size} messages contained measurements"
        Severity: Minor
        Found in lib/argos/ds.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _extract_motm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def _extract_motm
      lambda {|response|
        # Scan for MOTM signature --uuid:*
        if response.raw =~ (/^(--[\w:-]+)--$/)
          # Get the last message, which is -2 because of the trailing --
        Severity: Minor
        Found in lib/argos/soap.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method programs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def programs
      platformList = getPlatformList
      if platformList.key?("data") and platformList["data"].key?("program")
        
        platformList_data_program = platformList["data"]["program"].is_a?(Array) ? platformList["data"]["program"] : [platformList["data"]["program"]]
        Severity: Minor
        Found in lib/argos/soap.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                active.each_with_index do |a,m|
          log.debug "Active [#{m+1}/#{active.size}]: #{a.reject{|k,v| k =~ /location/i }.to_json}"
        Severity: Minor
        Found in lib/argos/download.rb and 1 other location - About 15 mins to fix
        lib/argos/download.rb on lines 60..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                inactive.each_with_index do |i,n|
          log.debug "Inactive [#{n+1}/#{inactive.size}]: #{i.reject{|k,v| k =~ /location/i }.to_json}"
        Severity: Minor
        Found in lib/argos/download.rb and 1 other location - About 15 mins to fix
        lib/argos/download.rb on lines 57..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language