Sign upLogin

npolar/argos-ruby

View on GitHub
Star
lib/argos/diag.rb

Summary

Maintainability
C
1 day
Test Coverage

Method parse has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def parse(filename=nil)
      if filename.nil?
        filename = @filename
      end
Severity: Major
Found in lib/argos/diag.rb - About 2 hrs to fix

    Method create_diag_hash has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def create_diag_hash(contact="")
      platform = contact[/^(\d{5,})/,1]
      location_data = contact[/Date : (\d{2}.\d{2}.\d{2} \d{2}:\d{2}:\d{2})/,1]
      contact_time = convert_date(location_data) unless location_data ==nil
      lc = contact[/LC : (3|2|1|0|A|B|Z)/,1]
    Severity: Major
    Found in lib/argos/diag.rb - About 2 hrs to fix

      Method parse has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def parse(filename=nil)
      if filename.nil?
        filename = @filename
      end
      Severity: Minor
      Found in lib/argos/diag.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create_diag_hash has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def create_diag_hash(contact="")
      platform = contact[/^(\d{5,})/,1]
      location_data = contact[/Date : (\d{2}.\d{2}.\d{2} \d{2}:\d{2}:\d{2})/,1]
      contact_time = convert_date(location_data) unless location_data ==nil
      lc = contact[/LC : (3|2|1|0|A|B|Z)/,1]
      Severity: Minor
      Found in lib/argos/diag.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status