nudesign/media_magick

View on GitHub

Showing 9 of 9 total issues

Function pluploadIt has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  $.fn.pluploadIt = function (options) {

    var settings = $.extend({
      browse_button:        'pickAttachments', // triggers modal to select files
      container:            'attachmentUploader',
Severity: Major
Found in app/assets/javascripts/media_magick/plupload_it.js - About 3 hrs to fix

    Function toggleSortable has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      toggleSortable: function (parentNode, updateUrl, options) {
        if (parentNode === undefined) { return 'error - no node specified'; }
    
        var settings = $.extend({
                                  'linkSelector': 'a.toggleSortable',
    Severity: Minor
    Found in app/assets/javascripts/media_magick/toggleSortable.js - About 1 hr to fix

      Function toggleSortable has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        toggleSortable: function (parentNode, updateUrl, options) {
          if (parentNode === undefined) { return 'error - no node specified'; }
      
          var settings = $.extend({
                                    'linkSelector': 'a.toggleSortable',
      Severity: Minor
      Found in app/assets/javascripts/media_magick/toggleSortable.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create_attaches_class has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def create_attaches_class(name, options, attaches_block, &block)
              klass = Class.new do
                include Mongoid::Document
                extend CarrierWave::Mount
      
      
      Severity: Minor
      Found in lib/media_magick/model.rb - About 1 hr to fix

        Method to_html has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def to_html(options = {})
                valid?
        
                case @service
                when 'youtube'
        Severity: Minor
        Found in lib/media_magick/video/parser.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method attaches_one has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def attaches_one(name, options = {})
                attaches_block = block_given? ? Proc.new : nil
        
                name_camelcase = create_attaches_class(name, options, attaches_block) do
                  if options[:allow_videos]
        Severity: Minor
        Found in lib/media_magick/model.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method attaches_many has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def attaches_many(name, options = {})
                attaches_block = block_given? ? Proc.new : nil
        
                name_camelcase = create_attaches_class(name, options, attaches_block) do
                  if options[:allow_videos]
        Severity: Minor
        Found in lib/media_magick/model.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create_attaches_class has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def create_attaches_class(name, options, attaches_block, &block)
                klass = Class.new do
                  include Mongoid::Document
                  extend CarrierWave::Mount
        
        
        Severity: Minor
        Found in lib/media_magick/model.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def create
              if !params[:embedded_in_model].blank?
                embedded_in = params[:embedded_in_model].constantize.find(params[:embedded_in_id])
                obj = embedded_in.send(params[:model].pluralize.downcase).find(params[:id])
              else
        Severity: Minor
        Found in app/controllers/media_magick/attach_controller.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language