nukeop/nuclear

View on GitHub

Showing 663 of 663 total issues

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  it('should display empty state', () => {
    const { component } = mountComponent();
    expect(component.asFragment()).toMatchSnapshot();
  });
packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 18..21
packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 21..24
packages/app/app/containers/DashboardContainer/DashboardContainer.test.tsx on lines 90..93
packages/app/app/containers/DownloadsContainer/DownloadsContainer.test.tsx on lines 25..28
packages/app/app/containers/FavoritesContainer/FavoritesContainer.tracks.test.tsx on lines 40..43
packages/app/app/containers/LibraryViewContainer/LibraryViewContainer.test.tsx on lines 22..26
packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx on lines 33..36
packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 25..28
packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 39..42
packages/app/app/containers/PluginsContainer/PluginsContainer.test.tsx on lines 17..20
packages/app/app/containers/SearchBoxContainer/SearchBoxContainer.test.tsx on lines 16..20
packages/app/app/containers/SearchResultsContainer/SearchResultsContainer.test.tsx on lines 20..23
packages/app/app/containers/SettingsContainer/SettingsContainer.test.tsx on lines 32..35
packages/app/app/containers/StreamVerificationContainer/StreamVerificationContainer.test.tsx on lines 20..23
packages/app/app/containers/UserPanelContainer/UserPanelContainer.test.tsx on lines 24..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  it('should display a playlist', () => {
    const { component } = mountComponent();
    expect(component.asFragment()).toMatchSnapshot();
  });
packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 18..21
packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 21..24
packages/app/app/containers/DashboardContainer/DashboardContainer.test.tsx on lines 90..93
packages/app/app/containers/DownloadsContainer/DownloadsContainer.test.tsx on lines 25..28
packages/app/app/containers/FavoritesContainer/FavoritesContainer.albums.test.tsx on lines 37..40
packages/app/app/containers/FavoritesContainer/FavoritesContainer.tracks.test.tsx on lines 40..43
packages/app/app/containers/LibraryViewContainer/LibraryViewContainer.test.tsx on lines 22..26
packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx on lines 33..36
packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 39..42
packages/app/app/containers/PluginsContainer/PluginsContainer.test.tsx on lines 17..20
packages/app/app/containers/SearchBoxContainer/SearchBoxContainer.test.tsx on lines 16..20
packages/app/app/containers/SearchResultsContainer/SearchResultsContainer.test.tsx on lines 20..23
packages/app/app/containers/SettingsContainer/SettingsContainer.test.tsx on lines 32..35
packages/app/app/containers/StreamVerificationContainer/StreamVerificationContainer.test.tsx on lines 20..23
packages/app/app/containers/UserPanelContainer/UserPanelContainer.test.tsx on lines 24..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  it('should display downloads', () => {
    const { component } = mountComponent();
    expect(component.asFragment()).toMatchSnapshot();
  });
packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 18..21
packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 21..24
packages/app/app/containers/DashboardContainer/DashboardContainer.test.tsx on lines 90..93
packages/app/app/containers/FavoritesContainer/FavoritesContainer.albums.test.tsx on lines 37..40
packages/app/app/containers/FavoritesContainer/FavoritesContainer.tracks.test.tsx on lines 40..43
packages/app/app/containers/LibraryViewContainer/LibraryViewContainer.test.tsx on lines 22..26
packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx on lines 33..36
packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 25..28
packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 39..42
packages/app/app/containers/PluginsContainer/PluginsContainer.test.tsx on lines 17..20
packages/app/app/containers/SearchBoxContainer/SearchBoxContainer.test.tsx on lines 16..20
packages/app/app/containers/SearchResultsContainer/SearchResultsContainer.test.tsx on lines 20..23
packages/app/app/containers/SettingsContainer/SettingsContainer.test.tsx on lines 32..35
packages/app/app/containers/StreamVerificationContainer/StreamVerificationContainer.test.tsx on lines 20..23
packages/app/app/containers/UserPanelContainer/UserPanelContainer.test.tsx on lines 24..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  it('should display all playlists', async () => {
    const { component } = mountComponent();
    expect(component.asFragment()).toMatchSnapshot();
  });
packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 18..21
packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 21..24
packages/app/app/containers/DashboardContainer/DashboardContainer.test.tsx on lines 90..93
packages/app/app/containers/DownloadsContainer/DownloadsContainer.test.tsx on lines 25..28
packages/app/app/containers/FavoritesContainer/FavoritesContainer.albums.test.tsx on lines 37..40
packages/app/app/containers/FavoritesContainer/FavoritesContainer.tracks.test.tsx on lines 40..43
packages/app/app/containers/LibraryViewContainer/LibraryViewContainer.test.tsx on lines 22..26
packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx on lines 33..36
packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 25..28
packages/app/app/containers/PluginsContainer/PluginsContainer.test.tsx on lines 17..20
packages/app/app/containers/SearchBoxContainer/SearchBoxContainer.test.tsx on lines 16..20
packages/app/app/containers/SearchResultsContainer/SearchResultsContainer.test.tsx on lines 20..23
packages/app/app/containers/SettingsContainer/SettingsContainer.test.tsx on lines 32..35
packages/app/app/containers/StreamVerificationContainer/StreamVerificationContainer.test.tsx on lines 20..23
packages/app/app/containers/UserPanelContainer/UserPanelContainer.test.tsx on lines 24..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    ipcRenderer.on(IpcEvents[getType(DownloadsActions.onDownloadFinished)], (event, data) => {
      this.props.actions.onDownloadFinished(data);
    });
Severity: Minor
Found in packages/app/app/containers/IpcContainer/index.js and 1 other location - About 45 mins to fix
packages/app/app/containers/IpcContainer/index.js on lines 67..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  it('should display an album', () => {
    const { component } = mountComponent();
    expect(component.asFragment()).toMatchSnapshot();
  });
packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 21..24
packages/app/app/containers/DashboardContainer/DashboardContainer.test.tsx on lines 90..93
packages/app/app/containers/DownloadsContainer/DownloadsContainer.test.tsx on lines 25..28
packages/app/app/containers/FavoritesContainer/FavoritesContainer.albums.test.tsx on lines 37..40
packages/app/app/containers/FavoritesContainer/FavoritesContainer.tracks.test.tsx on lines 40..43
packages/app/app/containers/LibraryViewContainer/LibraryViewContainer.test.tsx on lines 22..26
packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx on lines 33..36
packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 25..28
packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 39..42
packages/app/app/containers/PluginsContainer/PluginsContainer.test.tsx on lines 17..20
packages/app/app/containers/SearchBoxContainer/SearchBoxContainer.test.tsx on lines 16..20
packages/app/app/containers/SearchResultsContainer/SearchResultsContainer.test.tsx on lines 20..23
packages/app/app/containers/SettingsContainer/SettingsContainer.test.tsx on lines 32..35
packages/app/app/containers/StreamVerificationContainer/StreamVerificationContainer.test.tsx on lines 20..23
packages/app/app/containers/UserPanelContainer/UserPanelContainer.test.tsx on lines 24..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    ipcRenderer.on(IpcEvents[getType(DownloadsActions.onDownloadStarted)], (event, data) => {
      this.props.actions.onDownloadStarted(data);
    });
Severity: Minor
Found in packages/app/app/containers/IpcContainer/index.js and 1 other location - About 45 mins to fix
packages/app/app/containers/IpcContainer/index.js on lines 73..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const getTrackArtist = (track: Track) => _.isString(track?.artist)
  ? track?.artist
  : track?.artist?.name;
Severity: Minor
Found in packages/ui/lib/utils.ts and 1 other location - About 45 mins to fix
packages/main/src/utils/tracks.ts on lines 6..8

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const getTrackArtist = (track: TrackType) => _.isString(track?.artist)
  ? track?.artist
  : track?.artist?.name;
Severity: Minor
Found in packages/main/src/utils/tracks.ts and 1 other location - About 45 mins to fix
packages/ui/lib/utils.ts on lines 37..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  case ImportFavs.FAV_IMPORT_INIT:
    return Object.assign({}, state, {
      lastFmFavImportStatus: action.payload.lastFmFavImportStatus,
      lastFmFavImportMessage: action.payload.lastFmFavImportMessage
    });
Severity: Minor
Found in packages/app/app/reducers/importfavs.ts and 1 other location - About 40 mins to fix
packages/app/app/reducers/scrobbling.ts on lines 16..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const getCoverForRelease = (releaseId: string): Promise<CoverArtArchiveResult> => {
  return fetch(`${apiUrl}/release/${releaseId}/front`);
};
Severity: Minor
Found in packages/core/src/rest/CoverArtArchive.ts and 1 other location - About 40 mins to fix
packages/core/src/rest/CoverArtArchive.ts on lines 8..10

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  return <td {...cell.getCellProps() as TdHTMLAttributes<HTMLTableCellElement>}
    className={styles.date_cell}
  >
    {value}
  </td>;
Severity: Minor
Found in packages/ui/lib/components/TrackTable/Cells/DateCell.tsx and 1 other location - About 40 mins to fix
packages/ui/lib/components/Playlists/Cells/TitleCell.tsx on lines 11..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    }, {
      id: 'minimize',
      name: t('actions.minimize'),
      icon: 'window minimize',
      category: t('categories.application'),
Severity: Major
Found in packages/app/app/containers/CommandPaletteContainer/hooks.ts and 2 other locations - About 40 mins to fix
packages/app/app/containers/CommandPaletteContainer/hooks.ts on lines 111..117
packages/app/app/containers/CommandPaletteContainer/hooks.ts on lines 123..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

}) => <td
  {...cell.getCellProps() as TdHTMLAttributes<HTMLTableCellElement>}
  className={styles.title_cell}
>
  {value}
Severity: Minor
Found in packages/ui/lib/components/Playlists/Cells/TitleCell.tsx and 1 other location - About 40 mins to fix
packages/ui/lib/components/TrackTable/Cells/DateCell.tsx on lines 8..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    fetchMock.delete({
      url: 'http://verification.nuclear/stream-mappings/unverify',
      body: {
        stream_id: 'CuklIb9d3fI',
        artist: 'test artist 1',
packages/app/app/containers/StreamVerificationContainer/StreamVerificationContainer.test.tsx on lines 97..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    }, {
      id: 'quit',
      name: t('actions.quit'),
      icon: 'power off',
      category: t('categories.application'),
Severity: Major
Found in packages/app/app/containers/CommandPaletteContainer/hooks.ts and 2 other locations - About 40 mins to fix
packages/app/app/containers/CommandPaletteContainer/hooks.ts on lines 117..123
packages/app/app/containers/CommandPaletteContainer/hooks.ts on lines 123..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    }, {
      id: 'maximize',
      name: t('actions.maximize'),
      icon: 'window maximize',
      category: t('categories.application'),
Severity: Major
Found in packages/app/app/containers/CommandPaletteContainer/hooks.ts and 2 other locations - About 40 mins to fix
packages/app/app/containers/CommandPaletteContainer/hooks.ts on lines 111..117
packages/app/app/containers/CommandPaletteContainer/hooks.ts on lines 117..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  case Scrobbling.LASTFM_LOGIN:
    return Object.assign({}, state, {
      lastFmName: action.payload.name,
      lastFmSessionKey: action.payload.sessionKey
    });
Severity: Minor
Found in packages/app/app/reducers/scrobbling.ts and 1 other location - About 40 mins to fix
packages/app/app/reducers/importfavs.ts on lines 11..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    fetchMock.post({ url: 'http://verification.nuclear/stream-mappings/verify', body: {
      stream_id: 'CuklIb9d3fI',
      artist: 'test artist 1',
      title: 'test track 1',
      source: 'Test Stream Provider',
packages/app/app/containers/StreamVerificationContainer/StreamVerificationContainer.test.tsx on lines 126..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const onPlayNext = useCallback((track: Track) => {
    dispatch(queueActions.playNext(queueActions.toQueueItem(track)));
  }, [dispatch]);
Severity: Minor
Found in packages/app/app/containers/TrackTableContainer/index.tsx and 1 other location - About 40 mins to fix
packages/app/app/containers/TrackTableContainer/index.tsx on lines 51..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language