nukeop/nuclear

View on GitHub

Showing 451 of 451 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        album={{
          title: 'test album',
          artist: {
            name: 'test artist'
          },
Severity: Major
Found in packages/ui/stories/albumPreview.stories.js and 1 other location - About 4 hrs to fix
packages/ui/stories/albumPreview.stories.js on lines 55..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        <div className={styles.row}>
          <PlaylistResults
            playlistSearchStarted={this.props.playlistSearchStarted}
            playlistSearchResults={this.props.playlistSearchResults}
            addToQueue={this.props.addToQueue}
packages/app/app/components/SearchResults/index.js on lines 89..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      <Tab.Pane attached={false}>
        <PlaylistResults
          playlistSearchStarted={this.props.playlistSearchStarted}
          playlistSearchResults={this.props.playlistSearchResults}
          addToQueue={this.props.addToQueue}
Severity: Major
Found in packages/app/app/components/SearchResults/index.js and 1 other location - About 4 hrs to fix
packages/app/app/components/SearchResults/AllResults/index.js on lines 59..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

  it('search for podcasts', async () => {
    mockFetch('test');
    mockFetch([{ test: 'test data' }]);
    const json = await (await rest.iTunes.podcastSearch('Programming Throwdown', '1')).json();
    expect(fetch).toHaveBeenCalledTimes(1);
Severity: Major
Found in packages/core/src/rest/itunes.test.ts and 7 other locations - About 3 hrs to fix
packages/core/src/rest/itunes.test.ts on lines 27..33
packages/core/src/rest/itunes.test.ts on lines 43..49
packages/core/src/rest/itunes.test.ts on lines 57..63
packages/core/src/rest/itunes.test.ts on lines 65..71
packages/core/src/rest/itunes.test.ts on lines 73..79
packages/core/src/rest/itunes.test.ts on lines 81..87
packages/core/src/rest/itunes.test.ts on lines 97..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

  it('search for episodes', async () => {
    mockFetch('test');
    mockFetch([{ test: 'test data' }]);
    const json = await (await rest.iTunes.episodesSearch('Programming Throwdown', '1')).json();
    expect(fetch).toHaveBeenCalledTimes(1);
Severity: Major
Found in packages/core/src/rest/itunes.test.ts and 7 other locations - About 3 hrs to fix
packages/core/src/rest/itunes.test.ts on lines 19..25
packages/core/src/rest/itunes.test.ts on lines 43..49
packages/core/src/rest/itunes.test.ts on lines 57..63
packages/core/src/rest/itunes.test.ts on lines 65..71
packages/core/src/rest/itunes.test.ts on lines 73..79
packages/core/src/rest/itunes.test.ts on lines 81..87
packages/core/src/rest/itunes.test.ts on lines 97..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

  it('search for music', async () => {
    mockFetch('test');
    mockFetch([{ test: 'test data' }]);
    const json = await (await rest.iTunes.musicSearch('We Will Rock You', '1')).json();
    expect(fetch).toHaveBeenCalledTimes(1);
Severity: Major
Found in packages/core/src/rest/itunes.test.ts and 7 other locations - About 3 hrs to fix
packages/core/src/rest/itunes.test.ts on lines 19..25
packages/core/src/rest/itunes.test.ts on lines 27..33
packages/core/src/rest/itunes.test.ts on lines 43..49
packages/core/src/rest/itunes.test.ts on lines 57..63
packages/core/src/rest/itunes.test.ts on lines 65..71
packages/core/src/rest/itunes.test.ts on lines 81..87
packages/core/src/rest/itunes.test.ts on lines 97..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

  it('search an artist details by artistid', async () => {
    mockFetch('test');
    mockFetch([{ test: 'test data' }]);
    const json = await (await rest.iTunes.artistDetailsSearch('3296287', '1')).json();
    expect(fetch).toHaveBeenCalledTimes(1);
Severity: Major
Found in packages/core/src/rest/itunes.test.ts and 7 other locations - About 3 hrs to fix
packages/core/src/rest/itunes.test.ts on lines 19..25
packages/core/src/rest/itunes.test.ts on lines 27..33
packages/core/src/rest/itunes.test.ts on lines 43..49
packages/core/src/rest/itunes.test.ts on lines 57..63
packages/core/src/rest/itunes.test.ts on lines 65..71
packages/core/src/rest/itunes.test.ts on lines 73..79
packages/core/src/rest/itunes.test.ts on lines 97..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function loadBestNewTracks() {
  return dispatch => {
    dispatch(loadBestNewTracksAction.request());
    getBestNewTracks()
      .then(tracks => {
Severity: Major
Found in packages/app/app/actions/dashboard.ts and 1 other location - About 3 hrs to fix
packages/app/app/actions/dashboard.ts on lines 43..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

  it('search for albums', async () => {
    mockFetch('test');
    mockFetch([{ test: 'test data' }]);
    const json = await (await rest.iTunes.albumSearch('Live at Wembley Stadium', '1')).json();
    expect(fetch).toHaveBeenCalledTimes(1);
Severity: Major
Found in packages/core/src/rest/itunes.test.ts and 7 other locations - About 3 hrs to fix
packages/core/src/rest/itunes.test.ts on lines 19..25
packages/core/src/rest/itunes.test.ts on lines 27..33
packages/core/src/rest/itunes.test.ts on lines 43..49
packages/core/src/rest/itunes.test.ts on lines 57..63
packages/core/src/rest/itunes.test.ts on lines 73..79
packages/core/src/rest/itunes.test.ts on lines 81..87
packages/core/src/rest/itunes.test.ts on lines 97..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

  it('search for artists', async () => {
    mockFetch('test');
    mockFetch([{ test: 'test data' }]);
    const json = await (await rest.iTunes.artistSearch('Queen', '1')).json();
    expect(fetch).toHaveBeenCalledTimes(1);
Severity: Major
Found in packages/core/src/rest/itunes.test.ts and 7 other locations - About 3 hrs to fix
packages/core/src/rest/itunes.test.ts on lines 19..25
packages/core/src/rest/itunes.test.ts on lines 27..33
packages/core/src/rest/itunes.test.ts on lines 43..49
packages/core/src/rest/itunes.test.ts on lines 65..71
packages/core/src/rest/itunes.test.ts on lines 73..79
packages/core/src/rest/itunes.test.ts on lines 81..87
packages/core/src/rest/itunes.test.ts on lines 97..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function loadBestNewAlbums() {
  return dispatch => {
    dispatch(loadBestNewAlbumsAction.request());
    getBestNewAlbums()
      .then(albums => {
Severity: Major
Found in packages/app/app/actions/dashboard.ts and 1 other location - About 3 hrs to fix
packages/app/app/actions/dashboard.ts on lines 63..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

  it('search for a podcast episodes by podcastid', async () => {
    mockFetch('test');
    mockFetch([{ test: 'test data' }]);
    const json = await (await rest.iTunes.getPodcastEpisodes('427166321', '1')).json();
    expect(fetch).toHaveBeenCalledTimes(1);
Severity: Major
Found in packages/core/src/rest/itunes.test.ts and 7 other locations - About 3 hrs to fix
packages/core/src/rest/itunes.test.ts on lines 19..25
packages/core/src/rest/itunes.test.ts on lines 27..33
packages/core/src/rest/itunes.test.ts on lines 57..63
packages/core/src/rest/itunes.test.ts on lines 65..71
packages/core/src/rest/itunes.test.ts on lines 73..79
packages/core/src/rest/itunes.test.ts on lines 81..87
packages/core/src/rest/itunes.test.ts on lines 97..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

  it('search an album songs by albumid', async () => {
    mockFetch('test');
    mockFetch([{ test: 'test data' }]);
    const json = await (await rest.iTunes.albumSongsSearch('1440806041', '1')).json();
    expect(fetch).toHaveBeenCalledTimes(1);
Severity: Major
Found in packages/core/src/rest/itunes.test.ts and 7 other locations - About 3 hrs to fix
packages/core/src/rest/itunes.test.ts on lines 19..25
packages/core/src/rest/itunes.test.ts on lines 27..33
packages/core/src/rest/itunes.test.ts on lines 43..49
packages/core/src/rest/itunes.test.ts on lines 57..63
packages/core/src/rest/itunes.test.ts on lines 65..71
packages/core/src/rest/itunes.test.ts on lines 73..79
packages/core/src/rest/itunes.test.ts on lines 81..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('search for a podcast by podcastid', async () => {
    mockFetch('test');
    mockFetch([{ test: 'test data' }]);
    const json = await (await rest.iTunes.getPodcast('427166321')).json();
    expect(fetch).toHaveBeenCalledTimes(1);
Severity: Major
Found in packages/core/src/rest/itunes.test.ts and 1 other location - About 3 hrs to fix
packages/core/src/rest/itunes.test.ts on lines 89..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('should search for tags after clicking his tag', async () => {
    const { component, history } = mountComponent();
    expect(history.location.pathname).toBe('/artist/test-artist-id');
    await waitFor(() => component.getByText(/#tag1/i).click());
    expect(history.location.pathname).toBe('/tag/tag1');
packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 32..37
packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 43..48
packages/app/app/containers/PlaylistsContainer/PlaylistContainer.test.tsx on lines 35..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('should search for similar artist after clicking his name', async () => {
    const { component, history } = mountComponent();
    expect(history.location.pathname).toBe('/artist/test-artist-id');
    await waitFor(() => component.getByText(/artist-similar-1/i).click());
    expect(history.location.pathname).toBe('/artist/artist-similar-id');
packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 32..37
packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 36..41
packages/app/app/containers/PlaylistsContainer/PlaylistContainer.test.tsx on lines 35..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('should go to playlist after click on it', async () => {
    const { component, history } = mountComponent();
    expect(history.location.pathname).toBe('/playlists');
    await waitFor(() => component.getByText(/test playlist 2/i).click());
    expect(history.location.pathname).toBe('/playlist/1');
packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 32..37
packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 36..41
packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 43..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('search an artist albums by artistid', async () => {
    mockFetch('test');
    mockFetch([{ test: 'test data' }]);
    const json = await (await rest.iTunes.artistAlbumsSearch('3296287')).json();
    expect(fetch).toHaveBeenCalledTimes(1);
Severity: Major
Found in packages/core/src/rest/itunes.test.ts and 1 other location - About 3 hrs to fix
packages/core/src/rest/itunes.test.ts on lines 35..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('should search for artist after clicking his name', async () => {
    const { component, history } = mountComponent();
    expect(history.location.pathname).toBe('/album/test-album-id');
    await waitFor(() => component.getByText(/test artist/i).click());
    expect(history.location.pathname).toBe('/artist/test-artist-id');
packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 36..41
packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 43..48
packages/app/app/containers/PlaylistsContainer/PlaylistContainer.test.tsx on lines 35..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function mockPodcastEpisodesResult has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function mockPodcastEpisodesResult() {
  global.fetch = jest.fn(() =>
    Promise.resolve({
      json: jest.fn(() => ({
        'resultCount': 2,
Severity: Major
Found in packages/core/src/plugins/meta/metaMocks/iTunesPodcastMocks.ts - About 3 hrs to fix
    Severity
    Category
    Status
    Source
    Language