Sign upLogin

nukeop/nuclear

View on GitHub
Star
packages/app/app/actions/toasts.ts

Summary

Maintainability
C
1 day
Test Coverage

Function generateNotification has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function generateNotification(title: string, details: string, icon:  Node | React.ReactElement<{
  src: string;
}>, type: {[type:string]: boolean}, settings: Setting[] | { [key: string]: unknown }) {
Severity: Minor
Found in packages/app/app/actions/toasts.ts - About 35 mins to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    export function success(title: string, details: string, icon:  Node | React.ReactElement<{
  src: string;
}>, settings: Setting[] | { [key: string]: unknown }) {
  return generateNotification(title, details, icon, {success: true}, settings);
}
    Severity: Major
    Found in packages/app/app/actions/toasts.ts and 3 other locations - About 2 hrs to fix
    packages/app/app/actions/toasts.ts on lines 19..23
    packages/app/app/actions/toasts.ts on lines 25..29
    packages/app/app/actions/toasts.ts on lines 37..41

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    export function error(title: string, details: string, icon:  Node | React.ReactElement<{
  src: string;
}>, settings: Setting[] | { [key: string]: unknown }) {
  return generateNotification(title, details, icon, {error: true}, settings);
}
    Severity: Major
    Found in packages/app/app/actions/toasts.ts and 3 other locations - About 2 hrs to fix
    packages/app/app/actions/toasts.ts on lines 25..29
    packages/app/app/actions/toasts.ts on lines 31..35
    packages/app/app/actions/toasts.ts on lines 37..41

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    export function warning(title: string, details: string, icon:  Node | React.ReactElement<{
  src: string;
}>, settings: Setting[] | { [key: string]: unknown }) {
  return generateNotification(title, details, icon, {warning: true}, settings);
}
    Severity: Major
    Found in packages/app/app/actions/toasts.ts and 3 other locations - About 2 hrs to fix
    packages/app/app/actions/toasts.ts on lines 19..23
    packages/app/app/actions/toasts.ts on lines 31..35
    packages/app/app/actions/toasts.ts on lines 37..41

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    export function info(title: string, details: string, icon:  Node | React.ReactElement<{
  src: string;
}>, settings: Setting[] | { [key: string]: unknown }) {
  return generateNotification(title, details, icon, {info: true}, settings);
}
    Severity: Major
    Found in packages/app/app/actions/toasts.ts and 3 other locations - About 2 hrs to fix
    packages/app/app/actions/toasts.ts on lines 19..23
    packages/app/app/actions/toasts.ts on lines 25..29
    packages/app/app/actions/toasts.ts on lines 31..35

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status