nukeop/nuclear

View on GitHub
packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx

Summary

Maintainability
F
3 days
Test Coverage

File PlaylistsContainer.test.tsx has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-disable @typescript-eslint/ban-ts-comment */
import { render, waitFor, fireEvent } from '@testing-library/react';
import React from 'react';
import fetchMock from 'fetch-mock';
import { createMemoryHistory } from 'history';

    Function mountComponent has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const mountComponent = (initialStore?: AnyProps, initStore = true) => {
        const initialState = initialStore ||
          buildStoreState()
            .withPlaylists()
            .withPlugins()

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        const mountComponent = (initialStore?: AnyProps, initStore = true) => {
          const initialState = initialStore ||
            buildStoreState()
              .withPlaylists()
              .withPlugins()
      packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 245..278

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 215.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        it('should go to playlist after clicking on it', async () => {
          const { component, history } = mountComponent();
          expect(history.location.pathname).toBe('/playlists');
          await waitFor(() => component.getByText(/test playlist 2/i).click());
          expect(history.location.pathname).toBe('/playlist/test-playlist-id-2');
      packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 34..39
      packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 37..42
      packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 44..49

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          expect(state.toasts.notifications).toContainEqual({
            title: 'import-fail-title',
            details: 'error-empty-data',
            id: expect.any(String),
            icon: null,
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 221..229
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 233..241

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          expect(state.toasts.notifications).toContainEqual({
            title: 'import-fail-title',
            details: 'error-empty-data',
            id: expect.any(String),
            icon: null,
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 221..229
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 245..253

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          expect(state.toasts.notifications).toContainEqual({
            title: 'import-fail-title',
            details: 'error-empty-data',
            id: expect.any(String),
            icon: null,
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 233..241
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 245..253

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          expect(state.playlists.localPlaylists.data).toEqual(
            expect.arrayContaining([
              expect.objectContaining({
                name: 'New playlist'
              })
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 89..93
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 146..150
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 159..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          expect(state.playlists.localPlaylists.data).toEqual(
            expect.arrayContaining([
              expect.objectContaining({
                name: 'new-empty-playlist'
              })]));
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 114..119
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 146..150
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 159..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          expect(state.playlists.localPlaylists.data).toEqual(
            expect.arrayContaining([
              expect.objectContaining({
                name: 'new-empty-playlist'
              })]));
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 89..93
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 114..119
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 159..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          expect(state.playlists.localPlaylists.data).toEqual(
            expect.arrayContaining([
              expect.objectContaining({
                name: 'New playlist'
              })
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 89..93
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 114..119
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 146..150

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 16 locations. Consider refactoring.
      Open

        it('should display all playlists', async () => {
          const { component } = mountComponent();
          expect(component.asFragment()).toMatchSnapshot();
        });
      packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 18..21
      packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 21..24
      packages/app/app/containers/DashboardContainer/DashboardContainer.test.tsx on lines 90..93
      packages/app/app/containers/DownloadsContainer/DownloadsContainer.test.tsx on lines 25..28
      packages/app/app/containers/FavoritesContainer/FavoritesContainer.albums.test.tsx on lines 37..40
      packages/app/app/containers/FavoritesContainer/FavoritesContainer.tracks.test.tsx on lines 40..43
      packages/app/app/containers/LibraryViewContainer/LibraryViewContainer.test.tsx on lines 22..26
      packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx on lines 33..36
      packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 25..28
      packages/app/app/containers/PluginsContainer/PluginsContainer.test.tsx on lines 17..20
      packages/app/app/containers/SearchBoxContainer/SearchBoxContainer.test.tsx on lines 16..20
      packages/app/app/containers/SearchResultsContainer/SearchResultsContainer.test.tsx on lines 20..23
      packages/app/app/containers/SettingsContainer/SettingsContainer.test.tsx on lines 32..35
      packages/app/app/containers/StreamVerificationContainer/StreamVerificationContainer.test.tsx on lines 20..23
      packages/app/app/containers/UserPanelContainer/UserPanelContainer.test.tsx on lines 24..27

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          expect(state.playlists.localPlaylists.data).not.toEqual([
            expect.objectContaining({
              name: ''
            })
          ]);
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 174..178
      packages/app/app/containers/TrackPopupContainer/TrackPopupContainer.test.tsx on lines 106..110

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          expect(state.playlists.localPlaylists.data).not.toEqual([
            expect.objectContaining({
              name: ''
            })
          ]);
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 132..136
      packages/app/app/containers/TrackPopupContainer/TrackPopupContainer.test.tsx on lines 106..110

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status