Sign upLogin

nukeop/nuclear

View on GitHub
Star
packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx

Summary

Maintainability
F
6 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should skip to the previous track when the f7 is clicked on mac', async () => {
    (isMac as jest.Mock).mockReturnValueOnce(true);
    const { store } = mountShortcuts({
      queue: {
        currentSong: 1,
Severity: Major
Found in packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx and 1 other location - About 1 day to fix
packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx on lines 107..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 254.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should not skip to the previous track when f7 is clicked and the os is not mac', async () => {
    (isMac as jest.Mock).mockReturnValueOnce(false);
    const { store } = mountShortcuts({
      queue: {
        currentSong: 1,
Severity: Major
Found in packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx and 1 other location - About 1 day to fix
packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx on lines 44..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 254.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should pause the current track when the f8 key is clicked and the song is currently playing on mac', async () => {
    (isMac as jest.Mock).mockReturnValueOnce(true);
    const { store } = mountShortcuts({
      player: {
        playbackStatus: 'PLAYING'
Severity: Major
Found in packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx and 1 other location - About 4 hrs to fix
packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx on lines 87..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 132.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should not pause the current track when the f8 key is clicked and the song is currently playing, when the os is not mac', async () => {
    (isMac as jest.Mock).mockReturnValueOnce(false);
    const { store } = mountShortcuts({
      player: {
        playbackStatus: 'PLAYING'
Severity: Major
Found in packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx and 1 other location - About 4 hrs to fix
packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx on lines 24..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 132.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should skip to the next track when the f9 is clicked on mac', async () => {
    (isMac as jest.Mock).mockReturnValueOnce(true);
    const { store } = mountShortcuts();
    fireEvent.keyDown(document.body, {key: 'F9', code: 'F9', which: 120});
    const state = store.getState();
Severity: Major
Found in packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx and 1 other location - About 4 hrs to fix
packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx on lines 99..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should not start playing the current track when the f8 key is clicked and the os is not mac', async () => {
    (isMac as jest.Mock).mockReturnValueOnce(false);
    const { store } = mountShortcuts();
    fireEvent.keyDown(document.body, {key: 'F8', code: 'F8', which: 119});
    const state = store.getState();
Severity: Major
Found in packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx and 1 other location - About 4 hrs to fix
packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx on lines 16..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should not skip to the next track when f9 is clicked and the os is not mac', async () => {
    (isMac as jest.Mock).mockReturnValueOnce(false);
    const { store } = mountShortcuts();
    fireEvent.keyDown(document.body, {key: 'F9', code: 'F9', which: 120});
    const state = store.getState();
Severity: Major
Found in packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx and 1 other location - About 4 hrs to fix
packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx on lines 36..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should start playing the current track when the f8 key is clicked on mac', async () => {
    (isMac as jest.Mock).mockReturnValueOnce(true);
    const { store } = mountShortcuts();
    fireEvent.keyDown(document.body, {key: 'F8', code: 'F8', which: 119});
    const state = store.getState();
Severity: Major
Found in packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx and 1 other location - About 4 hrs to fix
packages/app/app/containers/ShortcutsContainer/ShortcutsContainer.test.tsx on lines 79..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status