Sign upLogin

nunonamorado/sinatra-slack

View on GitHub
Star
lib/sinatra/slack.rb

Summary

Maintainability
A
1 hr
Test Coverage

Assignment Branch Condition size for actions_endpoint is too high. [17.23/15]
Open

    def actions_endpoint(path, quick_reply: '')
      set_endpoint(path, quick_reply) do
        action_pattern = self.class.get_pattern(action.name)
        raise 'Action not defined' unless action_pattern
Severity: Minor
Found in lib/sinatra/slack.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [12/10]
Open

    def set_endpoint(path, quick_reply, &block)
      raise 'No block given' unless block_given?

      define_method("#{path}_options", &block)
Severity: Minor
Found in lib/sinatra/slack.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method set_endpoint has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def set_endpoint(path, quick_reply, &block)
      raise 'No block given' unless block_given?

      define_method("#{path}_options", &block)
Severity: Minor
Found in lib/sinatra/slack.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status