Sign upLogin

nus-mtp/cs-modify

View on GitHub
Star

Showing 2,705 of 2,705 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if (data[i][column2Index].substring(0,1) == '-' || data[i][column2Index].substring(0,1) == 'U'){
                    data[i][column2Index] = -2;
                } else if (data[i][column2Index].substring(0,1) == '?'){
                    data[i][column2Index] = -1;
                }
Severity: Major
Found in static/javascripts/fixedAndTentaMounting.js and 1 other location - About 4 hrs to fix
static/javascripts/fixedAndTentaMounting.js on lines 43..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 116.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (data[i][column1Index].substring(0,1) == '-' || data[i][column1Index].substring(0,1) == 'U'){
                data[i][column1Index] = -2;
            } else if (data[i][column1Index].substring(0,1) == '?'){
                data[i][column1Index] = -1;
            }
Severity: Major
Found in static/javascripts/fixedAndTentaMounting.js and 1 other location - About 4 hrs to fix
static/javascripts/fixedAndTentaMounting.js on lines 50..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 116.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

def is_aysem_in_system(ay_sem):
    '''
        Returns the AY-Sem if given AY-Sem is found inside the system, otherwise return False
    '''
    ay_sems_in_system = get_all_ay_sems()
Severity: Major
Found in components/helper.py and 1 other location - About 4 hrs to fix
components/helper.py on lines 99..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

def is_aysem_in_system_and_is_future(ay_sem):
    '''
        Returns the aysem if given aysem is found inside the system AND is a future AY-Sem,
        otherwise return False
    '''
Severity: Major
Found in components/helper.py and 1 other location - About 4 hrs to fix
components/helper.py on lines 85..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    focusAreaBarChart = new CanvasJS.Chart("module-view-focus-area-bar-chart",
    {
        animationEnabled: true,
        axisY: {
            title: "Number of Students",
Severity: Major
Found in static/javascripts/individualModuleInfo.js and 3 other locations - About 3 hrs to fix
static/javascripts/individualModuleInfo.js on lines 2..26
static/javascripts/studentEnrollment.js on lines 2..26
static/javascripts/studentEnrollment.js on lines 54..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    studentYearBarChart = new CanvasJS.Chart("enrollment-student-year-bar-chart",
    {
        animationEnabled: true,
        axisY: {
            title: "Number of Students",
Severity: Major
Found in static/javascripts/studentEnrollment.js and 3 other locations - About 3 hrs to fix
static/javascripts/individualModuleInfo.js on lines 2..26
static/javascripts/individualModuleInfo.js on lines 54..78
static/javascripts/studentEnrollment.js on lines 54..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    focusAreaBarChart = new CanvasJS.Chart("enrollment-focus-area-bar-chart",
    {
        animationEnabled: true,
        axisY: {
            title: "Number of Students",
Severity: Major
Found in static/javascripts/studentEnrollment.js and 3 other locations - About 3 hrs to fix
static/javascripts/individualModuleInfo.js on lines 2..26
static/javascripts/individualModuleInfo.js on lines 54..78
static/javascripts/studentEnrollment.js on lines 2..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    studentYearBarChart = new CanvasJS.Chart("module-view-student-year-bar-chart",
    {
        animationEnabled: true,
        axisY: {
            title: "Number of Students",
Severity: Major
Found in static/javascripts/individualModuleInfo.js and 3 other locations - About 3 hrs to fix
static/javascripts/individualModuleInfo.js on lines 54..78
static/javascripts/studentEnrollment.js on lines 2..26
static/javascripts/studentEnrollment.js on lines 54..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function onload has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

window.onload = function () {
    studentYearBarChart = new CanvasJS.Chart("enrollment-student-year-bar-chart",
    {
        animationEnabled: true,
        axisY: {
Severity: Major
Found in static/javascripts/studentEnrollment.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if sem2_mounting is True:
                    old_mounting = model.get_mounting_of_target_tenta_ay_sem(module_code,
                                                                             target_aysem)
                    if old_mounting is True:
                        outcome = model.update_quota(module_code,
    Severity: Major
    Found in components/handlers/edit_all_mountings_and_quotas.py and 1 other location - About 3 hrs to fix
    components/handlers/edit_all_mountings_and_quotas.py on lines 117..127

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if sem1_mounting is True:
                    old_mounting = model.get_mounting_of_target_tenta_ay_sem(module_code,
                                                                             target_aysem)
                    if old_mounting is True:
                        outcome = model.update_quota(module_code,
    Severity: Major
    Found in components/handlers/edit_all_mountings_and_quotas.py and 1 other location - About 3 hrs to fix
    components/handlers/edit_all_mountings_and_quotas.py on lines 133..143

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function showFocusAreaBarChart() {
    document.getElementById('enrollment-focus-area-bar-chart').style.display = "block";
    document.getElementById('enrollment-focus-area-pie-chart').style.display = "none";
    document.getElementById('enrollment-focus-area-bar-chart-button').classList.add("active");
    document.getElementById('enrollment-focus-area-pie-chart-button').classList.remove("active");
    Severity: Major
    Found in static/javascripts/studentEnrollment.js and 7 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 146..152
    static/javascripts/individualModuleInfo.js on lines 154..160
    static/javascripts/individualModuleInfo.js on lines 162..168
    static/javascripts/individualModuleInfo.js on lines 170..176
    static/javascripts/studentEnrollment.js on lines 107..113
    static/javascripts/studentEnrollment.js on lines 115..121
    static/javascripts/studentEnrollment.js on lines 131..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function showFocusAreaPieChart() {
    document.getElementById('enrollment-focus-area-pie-chart').style.display = "block";
    document.getElementById('enrollment-focus-area-bar-chart').style.display = "none";
    document.getElementById('enrollment-focus-area-pie-chart-button').classList.add("active");
    document.getElementById('enrollment-focus-area-bar-chart-button').classList.remove("active");
    Severity: Major
    Found in static/javascripts/studentEnrollment.js and 7 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 146..152
    static/javascripts/individualModuleInfo.js on lines 154..160
    static/javascripts/individualModuleInfo.js on lines 162..168
    static/javascripts/individualModuleInfo.js on lines 170..176
    static/javascripts/studentEnrollment.js on lines 107..113
    static/javascripts/studentEnrollment.js on lines 115..121
    static/javascripts/studentEnrollment.js on lines 123..129

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function showFocusAreaPieChart() {
    document.getElementById('module-view-focus-area-pie-chart').style.display = "block";
    document.getElementById('module-view-focus-area-bar-chart').style.display = "none";
    document.getElementById('module-view-focus-area-pie-chart-button').classList.add("active");
    document.getElementById('module-view-focus-area-bar-chart-button').classList.remove("active");
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 7 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 146..152
    static/javascripts/individualModuleInfo.js on lines 154..160
    static/javascripts/individualModuleInfo.js on lines 162..168
    static/javascripts/studentEnrollment.js on lines 107..113
    static/javascripts/studentEnrollment.js on lines 115..121
    static/javascripts/studentEnrollment.js on lines 123..129
    static/javascripts/studentEnrollment.js on lines 131..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function showStudentYearBarChart() {
    document.getElementById('enrollment-student-year-bar-chart').style.display = "block";
    document.getElementById('enrollment-student-year-pie-chart').style.display = "none";
    document.getElementById('enrollment-student-year-bar-chart-button').classList.add("active");
    document.getElementById('enrollment-student-year-pie-chart-button').classList.remove("active");
    Severity: Major
    Found in static/javascripts/studentEnrollment.js and 7 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 146..152
    static/javascripts/individualModuleInfo.js on lines 154..160
    static/javascripts/individualModuleInfo.js on lines 162..168
    static/javascripts/individualModuleInfo.js on lines 170..176
    static/javascripts/studentEnrollment.js on lines 115..121
    static/javascripts/studentEnrollment.js on lines 123..129
    static/javascripts/studentEnrollment.js on lines 131..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function showStudentYearPieChart() {
    document.getElementById('module-view-student-year-pie-chart').style.display = "block";
    document.getElementById('module-view-student-year-bar-chart').style.display = "none";
    document.getElementById('module-view-student-year-pie-chart-button').classList.add("active");
    document.getElementById('module-view-student-year-bar-chart-button').classList.remove("active");
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 7 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 146..152
    static/javascripts/individualModuleInfo.js on lines 162..168
    static/javascripts/individualModuleInfo.js on lines 170..176
    static/javascripts/studentEnrollment.js on lines 107..113
    static/javascripts/studentEnrollment.js on lines 115..121
    static/javascripts/studentEnrollment.js on lines 123..129
    static/javascripts/studentEnrollment.js on lines 131..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function edit_prerequisite has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

    def edit_prerequisite(module_code, prereq_units):
    '''
        Changes the prerequisites of given module_code into a new
        set of prerequisites found in prereq_units.
        Returns true if successful, false otherwise.
    Severity: Minor
    Found in components/database.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function showStudentYearBarChart() {
    document.getElementById('module-view-student-year-bar-chart').style.display = "block";
    document.getElementById('module-view-student-year-pie-chart').style.display = "none";
    document.getElementById('module-view-student-year-bar-chart-button').classList.add("active");
    document.getElementById('module-view-student-year-pie-chart-button').classList.remove("active");
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 7 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 154..160
    static/javascripts/individualModuleInfo.js on lines 162..168
    static/javascripts/individualModuleInfo.js on lines 170..176
    static/javascripts/studentEnrollment.js on lines 107..113
    static/javascripts/studentEnrollment.js on lines 115..121
    static/javascripts/studentEnrollment.js on lines 123..129
    static/javascripts/studentEnrollment.js on lines 131..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function showFocusAreaBarChart() {
    document.getElementById('module-view-focus-area-bar-chart').style.display = "block";
    document.getElementById('module-view-focus-area-pie-chart').style.display = "none";
    document.getElementById('module-view-focus-area-bar-chart-button').classList.add("active");
    document.getElementById('module-view-focus-area-pie-chart-button').classList.remove("active");
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 7 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 146..152
    static/javascripts/individualModuleInfo.js on lines 154..160
    static/javascripts/individualModuleInfo.js on lines 170..176
    static/javascripts/studentEnrollment.js on lines 107..113
    static/javascripts/studentEnrollment.js on lines 115..121
    static/javascripts/studentEnrollment.js on lines 123..129
    static/javascripts/studentEnrollment.js on lines 131..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function showStudentYearPieChart() {
    document.getElementById('enrollment-student-year-pie-chart').style.display = "block";
    document.getElementById('enrollment-student-year-bar-chart').style.display = "none";
    document.getElementById('enrollment-student-year-pie-chart-button').classList.add("active");
    document.getElementById('enrollment-student-year-bar-chart-button').classList.remove("active");
    Severity: Major
    Found in static/javascripts/studentEnrollment.js and 7 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 146..152
    static/javascripts/individualModuleInfo.js on lines 154..160
    static/javascripts/individualModuleInfo.js on lines 162..168
    static/javascripts/individualModuleInfo.js on lines 170..176
    static/javascripts/studentEnrollment.js on lines 107..113
    static/javascripts/studentEnrollment.js on lines 123..129
    static/javascripts/studentEnrollment.js on lines 131..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language