Sign upLogin

nuts-foundation/nuts-node

View on GitHub
Star
pki/validator.go

Summary

Maintainability
A
2 hrs
Test Coverage
B
84%

Method validator.sync has 53 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (v *validator) sync() {
    // Use a WaitGroup to track when background goroutines are complete
    wg := &sync.WaitGroup{}

    // maximum time between updates
Severity: Minor
Found in pki/validator.go - About 1 hr to fix

    Method validator.sync has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
    Open

    func (v *validator) sync() {
    // Use a WaitGroup to track when background goroutines are complete
    wg := &sync.WaitGroup{}

    // maximum time between updates
    Severity: Minor
    Found in pki/validator.go - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validator.validateCert has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
    Open

    func (v *validator) validateCert(cert *x509.Certificate) error {
    // Check if a denylist is in use
    if v.denylist != nil {
        // Validate the cert against the denylist
        if err := v.denylist.ValidateCert(cert); err != nil {
    Severity: Minor
    Found in pki/validator.go - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status