Sign upLogin

nuts-foundation/nuts-node

View on GitHub
Star
vcr/verifier/verifier.go

Summary

Maintainability
A
3 hrs
Test Coverage
A
94%

Method verifier.Verify has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func (v verifier) Verify(credentialToVerify vc.VerifiableCredential, allowUntrusted bool, checkSignature bool, validAt *time.Time) error {
    // it must have valid content
    validator := credential.FindValidator(credentialToVerify)
    if err := validator.Validate(credentialToVerify); err != nil {
        return err
Severity: Minor
Found in vcr/verifier/verifier.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method verifier.Verify has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (v verifier) Verify(credentialToVerify vc.VerifiableCredential, allowUntrusted bool, checkSignature bool, validAt *time.Time) error {
    // it must have valid content
    validator := credential.FindValidator(credentialToVerify)
    if err := validator.Validate(credentialToVerify); err != nil {
        return err
Severity: Minor
Found in vcr/verifier/verifier.go - About 1 hr to fix

    Function NewVerifier has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func NewVerifier(store Store, didResolver resolver.DIDResolver, keyResolver resolver.KeyResolver, jsonldManager jsonld.JSONLD, trustConfig *trust.Config, credentialStatus *revocation.StatusList2021) Verifier {
    Severity: Minor
    Found in vcr/verifier/verifier.go - About 45 mins to fix

      Method verifier.doVerifyVP has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func (v verifier) doVerifyVP(vcVerifier Verifier, presentation vc.VerifiablePresentation, verifyVCs bool, allowUntrustedVCs bool, validAt *time.Time) ([]vc.VerifiableCredential, error) {
      Severity: Minor
      Found in vcr/verifier/verifier.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status