Sign upLogin

nycJSorg/angular-presentation

View on GitHub
Star
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      {
        path: 'create-first-app',
        loadChildren: () =>
          import('./create-first-app/create-first-app.module').then(
            m => m.CreateFirstAppModule
Severity: Major
Found in apps/codelab/src/app/codelabs/angular/angular-routing.module.ts and 3 other locations - About 1 hr to fix
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 50..59
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 60..72
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 73..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      {
        path: 'dependency-injection',
        loadChildren: () =>
          import('./dependency-injection/dependency-injection.module').then(
            m => m.DependencyInjectionModule
Severity: Major
Found in apps/codelab/src/app/codelabs/angular/angular-routing.module.ts and 3 other locations - About 1 hr to fix
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 37..49
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 50..59
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 73..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      {
        path: 'templates',
        loadChildren: () =>
          import('./templates/templates.module').then(m => m.TemplatesModule),
        name: 'Templates',
Severity: Major
Found in apps/codelab/src/app/codelabs/angular/angular-routing.module.ts and 3 other locations - About 1 hr to fix
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 37..49
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 60..72
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 73..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      {
        path: 'component-tree',
        loadChildren: () =>
          import('./component-tree/component-tree.module').then(
            m => m.ComponentTreeModule
Severity: Major
Found in apps/codelab/src/app/codelabs/angular/angular-routing.module.ts and 3 other locations - About 1 hr to fix
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 37..49
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 50..59
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 60..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      {
        path: 'structural-directives',
        loadChildren: () =>
          import('./structural-directives/structural-directives.module').then(
            m => m.StructuralDirectivesModule
Severity: Major
Found in apps/codelab/src/app/codelabs/angular/angular-routing.module.ts and 7 other locations - About 1 hr to fix
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 25..36
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 105..115
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 116..124
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 125..135
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 136..145
apps/kirjs/src/app/kirjs.module.ts on lines 21..29
apps/kirjs/src/app/kirjs.module.ts on lines 30..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      {
        path: 'material',
        loadChildren: () =>
          import('./material/material.module').then(
            m => m.MaterialCodelabModule
Severity: Major
Found in apps/codelab/src/app/codelabs/angular/angular-routing.module.ts and 7 other locations - About 1 hr to fix
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 25..36
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 116..124
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 125..135
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 136..145
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 146..156
apps/kirjs/src/app/kirjs.module.ts on lines 21..29
apps/kirjs/src/app/kirjs.module.ts on lines 30..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      {
        path: 'pipes',
        loadChildren: () =>
          import('./pipes/pipes.module').then(m => m.PipesModule),
        name: 'Pipes',
Severity: Major
Found in apps/codelab/src/app/codelabs/angular/angular-routing.module.ts and 7 other locations - About 1 hr to fix
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 25..36
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 105..115
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 116..124
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 125..135
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 146..156
apps/kirjs/src/app/kirjs.module.ts on lines 21..29
apps/kirjs/src/app/kirjs.module.ts on lines 30..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      {
        path: 'typescript',
        loadChildren: () =>
          import('./typescript/typescript.module').then(
            m => m.TypeScriptModule
Severity: Major
Found in apps/codelab/src/app/codelabs/angular/angular-routing.module.ts and 7 other locations - About 1 hr to fix
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 105..115
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 116..124
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 125..135
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 136..145
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 146..156
apps/kirjs/src/app/kirjs.module.ts on lines 21..29
apps/kirjs/src/app/kirjs.module.ts on lines 30..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      {
        path: 'angular-cli',
        loadChildren: () =>
          import('./angular-cli/angular-cli.module').then(
            m => m.AngularCliModule
Severity: Major
Found in apps/codelab/src/app/codelabs/angular/angular-routing.module.ts and 7 other locations - About 1 hr to fix
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 25..36
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 105..115
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 116..124
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 136..145
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 146..156
apps/kirjs/src/app/kirjs.module.ts on lines 21..29
apps/kirjs/src/app/kirjs.module.ts on lines 30..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      {
        path: 'forms',
        loadChildren: () =>
          import('./forms/forms.module').then(m => m.FormsCodelabModule),
        name: 'Forms',
Severity: Major
Found in apps/codelab/src/app/codelabs/angular/angular-routing.module.ts and 7 other locations - About 1 hr to fix
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 25..36
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 105..115
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 125..135
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 136..145
apps/codelab/src/app/codelabs/angular/angular-routing.module.ts on lines 146..156
apps/kirjs/src/app/kirjs.module.ts on lines 21..29
apps/kirjs/src/app/kirjs.module.ts on lines 30..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status