Sign upLogin

nycJSorg/angular-presentation

View on GitHub
Star
apps/kirjs/src/app/modules/binary/parser/binary-parser.ts

Summary

Maintainability
C
1 day
Test Coverage

BinaryParser has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

export class BinaryParser {
  type = 'object';
  private parser: BinaryObjectParser;

  constructor() {
Severity: Minor
Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      uInt24(name: string, config: any = {}) {
    return this.bit(name, {
      type: 'number',
      length: 24,
      converter: a => {
    Severity: Minor
    Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts and 1 other location - About 40 mins to fix
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 128..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      uInt32(name: string, config?: Partial<BaseConfig>) {
    return this.bit(name, {
      type: 'number',
      length: 32,
      converter: a => {
    Severity: Minor
    Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts and 1 other location - About 40 mins to fix
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 117..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      bit2(name: string, config?: Partial<BaseConfig>) {
    return this.bit(name, { length: 2, ...config });
  }
    Severity: Major
    Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts and 6 other locations - About 35 mins to fix
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 79..81
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 87..89
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 91..93
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 95..97
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 98..100
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 102..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      bit32(name: string, config?: Partial<BaseConfig>) {
    return this.bit(name, { length: 32, ...config });
  }
    Severity: Major
    Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts and 6 other locations - About 35 mins to fix
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 79..81
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 83..85
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 87..89
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 91..93
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 98..100
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 102..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      bit1(name: string, config?: Partial<BaseConfig>) {
    return this.bit(name, { length: 1, ...config });
  }
    Severity: Major
    Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts and 6 other locations - About 35 mins to fix
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 83..85
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 87..89
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 91..93
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 95..97
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 98..100
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 102..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      bit3(name: string, config?: Partial<BaseConfig>) {
    return this.bit(name, { length: 3, ...config });
  }
    Severity: Major
    Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts and 6 other locations - About 35 mins to fix
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 79..81
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 83..85
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 91..93
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 95..97
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 98..100
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 102..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      bit24(name: string, config?: Partial<BaseConfig>) {
    return this.bit(name, { length: 24, ...config });
  }
    Severity: Major
    Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts and 6 other locations - About 35 mins to fix
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 79..81
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 83..85
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 87..89
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 91..93
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 95..97
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 102..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      object(name: string, config?: Partial<BaseConfig>) {
    return this.bit(name, { length: 1, ...config });
  }
    Severity: Major
    Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts and 6 other locations - About 35 mins to fix
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 79..81
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 83..85
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 87..89
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 91..93
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 95..97
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 98..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      bit8(name: string, config?: Partial<BaseConfig>) {
    return this.bit(name, { length: 8, ...config });
  }
    Severity: Major
    Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts and 6 other locations - About 35 mins to fix
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 79..81
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 83..85
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 87..89
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 95..97
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 98..100
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 102..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      choice(name: string, config: any) {
    this.parser.addStep(name, new BinaryChoiceParser({ ...config }));
    return this;
  }
    Severity: Minor
    Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts and 2 other locations - About 30 mins to fix
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 52..55
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 57..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      bit(name: string, config: any) {
    this.parser.addStep(name, new BitParser({ ...config }));
    return this;
  }
    Severity: Minor
    Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts and 2 other locations - About 30 mins to fix
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 47..50
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 52..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      array(name: string, config: any) {
    this.parser.addStep(name, new BinaryArrayParser({ ...config }));
    return this;
  }
    Severity: Minor
    Found in apps/kirjs/src/app/modules/binary/parser/binary-parser.ts and 2 other locations - About 30 mins to fix
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 47..50
    apps/kirjs/src/app/modules/binary/parser/binary-parser.ts on lines 57..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status