Showing 7 of 11 total issues
Function _runQueue
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
_runQueue(queueName, eventData = {}) {
let queues = get(this, 'queues');
let orderedQueue = A(get(queues, queueName) || []).sortBy('priority').slice(); // copy, bro
this.debug(`[action-queue] Trying action queue of ${orderedQueue.length}`);
Function play
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
play(itemIdOrItem, options = {}) {
let itemModelName = this.itemModelName(itemIdOrItem);
let itemId = this.itemId(itemIdOrItem);
let recordRequest = this.fetchRecord(itemIdOrItem);
let newPlay = this.isNewPlay(itemIdOrItem);
Function _runQueue
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
_runQueue(queueName, eventData = {}) {
let queues = get(this, 'queues');
let orderedQueue = A(get(queues, queueName) || []).sortBy('priority').slice(); // copy, bro
this.debug(`[action-queue] Trying action queue of ${orderedQueue.length}`);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function didReceiveAttrs
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
didReceiveAttrs: diffAttrs('showTitle', function(changedAttrs, ...args) {
this._super(...args);
let isInitialRender = changedAttrs === null;
let isBumper = this.get('currentSound.metadata.playContext') === 'audio-bumper';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return STATES.PAUSED; // JIC
Function playState
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
playState: computed('isPlaying', 'isPaused', 'isLoading', 'wasMeasured', 'isExpandable', function() {
let { wasMeasured, isExpandable } = getProperties(this, 'wasMeasured', 'isExpandable');
if (isExpandable && !wasMeasured) {
return STATES.PAUSED; // consider it paused until we measure so we get full width of natural state
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function play
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
play(itemIdOrItem, options = {}) {
let itemModelName = this.itemModelName(itemIdOrItem);
let itemId = this.itemId(itemIdOrItem);
let recordRequest = this.fetchRecord(itemIdOrItem);
let newPlay = this.isNewPlay(itemIdOrItem);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"