oauth2-proxy/oauth2-proxy

View on GitHub
providers/logingov.go

Summary

Maintainability
A
3 hrs
Test Coverage
C
74%

Method LoginGovProvider.Redeem has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (p *LoginGovProvider) Redeem(ctx context.Context, _, code, codeVerifier string) (*sessions.SessionState, error) {
    if code == "" {
        return nil, ErrMissingCode
    }

Severity: Minor
Found in providers/logingov.go - About 1 hr to fix

    Method LoginGovProvider.Redeem has 6 return statements (exceeds 4 allowed).
    Open

    func (p *LoginGovProvider) Redeem(ctx context.Context, _, code, codeVerifier string) (*sessions.SessionState, error) {
        if code == "" {
            return nil, ErrMissingCode
        }
    
    
    Severity: Major
    Found in providers/logingov.go - About 40 mins to fix

      Function checkNonce has 5 return statements (exceeds 4 allowed).
      Open

      func checkNonce(idToken string, p *LoginGovProvider) (err error) {
          token, err := jwt.ParseWithClaims(idToken, &loginGovCustomClaims{}, func(_ *jwt.Token) (interface{}, error) {
              var pubkeys jose.JSONWebKeySet
              rerr := requests.New(p.PubJWKURL.String()).Do().UnmarshalInto(&pubkeys)
              if rerr != nil {
      Severity: Major
      Found in providers/logingov.go - About 35 mins to fix

        Method LoginGovProvider.configure has 5 return statements (exceeds 4 allowed).
        Open

        func (p *LoginGovProvider) configure(opts options.LoginGovOptions) error {
            pubJWKURL, err := url.Parse(opts.PubJWKURL)
            if err != nil {
                return fmt.Errorf("could not parse Public JWK URL: %v", err)
            }
        Severity: Major
        Found in providers/logingov.go - About 35 mins to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Invalid

          var (
              // Default Login URL for LoginGov.
              // Pre-parsed URL of https://secure.login.gov/openid_connect/authorize.
              loginGovDefaultLoginURL = &url.URL{
                  Scheme: "https",
          Severity: Major
          Found in providers/logingov.go and 3 other locations - About 35 mins to fix
          providers/digitalocean.go on lines 24..48
          providers/facebook.go on lines 24..49
          providers/keycloak.go on lines 25..49

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status