Sign upLogin

oc-shopaholic/oc-shopaholic-plugin

View on GitHub
Star
classes/event/offer/ExtendOfferFieldsHandler.php

Summary

Maintainability
A
1 hr
Test Coverage

Method extendFields has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function extendFields($obWidget)
    {
        $arAdditionFields = [
            'measure'  => [
                'label'       => 'lovata.shopaholic::lang.field.measure',
Severity: Minor
Found in classes/event/offer/ExtendOfferFieldsHandler.php - About 1 hr to fix

    Define a constant instead of duplicating this literal "label" 7 times.
    Open

                    'label'       => 'lovata.shopaholic::lang.field.measure',
    Severity: Critical
    Found in classes/event/offer/ExtendOfferFieldsHandler.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "number" 5 times.
    Open

                    'type'  => 'number',
    Severity: Critical
    Found in classes/event/offer/ExtendOfferFieldsHandler.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "lovata.shopaholic::lang.tab.dimensions" 7 times.
    Open

                    'tab'         => 'lovata.shopaholic::lang.tab.dimensions',
    Severity: Critical
    Found in classes/event/offer/ExtendOfferFieldsHandler.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    There are no issues that match your filters.

    Category
    Status