Sign upLogin

oc-shopaholic/oc-shopaholic-plugin

View on GitHub
Star
classes/helper/CommonMenuType.php

Summary

Maintainability
A
1 hr
Test Coverage

Function filterPageList has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    protected function filterPageList($obPageList)
    {
        $arCmsPageList = [];
        if (empty($obPageList) || $obPageList->isEmpty()) {
            return $arCmsPageList;
Severity: Minor
Found in classes/helper/CommonMenuType.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getCategoryMenuOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getCategoryMenuOptions($obCategoryList)
    {
        if (empty($obCategoryList) || $obCategoryList->isEmpty()) {
            return null;
        }
Severity: Minor
Found in classes/helper/CommonMenuType.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Variable "updated_at" is not in valid camel caps format
Open

            'mtime'   => $obCategoryItem->updated_at,
Severity: Minor
Found in classes/helper/CommonMenuType.php by phpcodesniffer

Abstract class name is not prefixed with "Abstract"
Open

abstract class CommonMenuType
Severity: Minor
Found in classes/helper/CommonMenuType.php by phpcodesniffer

There are no issues that match your filters.

Category
Status