Sign upLogin

oc-shopaholic/oc-shopaholic-plugin

View on GitHub
Star
classes/import/ImportBrandModelFromXML.php

Summary

Maintainability
C
1 day
Test Coverage

Define a constant instead of duplicating this literal "external_id" 3 times.
Open

        $this->arExistIDList = (array) Brand::whereNotNull('external_id')->pluck('external_id', 'id')->all();
Severity: Critical
Found in classes/import/ImportBrandModelFromXML.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function prepareImportSettings()
    {
        $this->arXMLFileList = XmlImportSettings::getValue('file_list');
        $this->sImageFolderPath = XmlImportSettings::getValue('image_folder');
        $this->sImageFolderPath = trim($this->sImageFolderPath, '/');
Severity: Major
Found in classes/import/ImportBrandModelFromXML.php and 2 other locations - About 1 day to fix
classes/import/ImportOfferModelFromXML.php on lines 194..211
classes/import/ImportProductModelFromXML.php on lines 206..223

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 229.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

    public function __construct()
    {
        $this->arExistIDList = (array) Brand::whereNotNull('external_id')->pluck('external_id', 'id')->all();
        $this->arExistIDList = array_filter($this->arExistIDList);
Severity: Major
Found in classes/import/ImportBrandModelFromXML.php and 4 other locations - About 1 hr to fix
classes/import/ImportCategoryModelFromXML.php on lines 36..44
classes/import/ImportOfferModelFromXML.php on lines 32..40
classes/import/ImportOfferPriceFromXML.php on lines 30..38
classes/import/ImportProductModelFromXML.php on lines 33..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Exception type missing for @throws tag in function comment
Open

     * @throws
Severity: Minor
Found in classes/import/ImportBrandModelFromXML.php by phpcodesniffer

Missing parameter name
Open

     * @param $obProgressBar
Severity: Minor
Found in classes/import/ImportBrandModelFromXML.php by phpcodesniffer

Doc comment for parameter "$obProgressBar" missing
Open

    /**
Severity: Minor
Found in classes/import/ImportBrandModelFromXML.php by phpcodesniffer

There are no issues that match your filters.

Category
Status