components/Breadcrumbs.php
Define a constant instead of duplicating this literal "active" 3 times. Open
Open
$arTagData['active'] = true;
- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() { prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times execute('action1'); release('action1'); }
Compliant Solution
ACTION_1 = 'action1'; function run() { prepare(ACTION_1); execute(ACTION_1); release(ACTION_1); }
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Variable "parent_id" is not in valid camel caps format Open
Open
$this->addCategoryData($obCategoryItem->parent_id);
- Exclude checks
Variable "parent_id" is not in valid camel caps format Open
Open
if (!empty($obCategoryItem->parent_id)) {
- Exclude checks
Variable "category_id" is not in valid camel caps format Open
Open
$this->addCategoryData($obTagItem->category_id);
- Exclude checks
Variable "category_id" is not in valid camel caps format Open
Open
$this->addCategoryData($obProductItem->category_id);
- Exclude checks