oc-shopaholic/oc-shopaholic-plugin

View on GitHub
components/CategoryPage.php

Summary

Maintainability
A
1 hr
Test Coverage

Function getElementByWildcard has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getElementByWildcard($sElementSlug)
    {
        $arSlugList = explode('/', $sElementSlug);
        if (empty($arSlugList)) {
            return null;
Severity: Minor
Found in components/CategoryPage.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return null;
Severity: Major
Found in components/CategoryPage.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return $obElement;
    Severity: Major
    Found in components/CategoryPage.php - About 30 mins to fix

      Reduce the number of returns of this function 6, down to the maximum allowed 3.
      Open

          protected function getElementByWildcard($sElementSlug)
      Severity: Major
      Found in components/CategoryPage.php by sonar-php

      Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

      Noncompliant Code Example

      With the default threshold of 3:

      function myFunction(){ // Noncompliant as there are 4 return statements
        if (condition1) {
          return true;
        } else {
          if (condition2) {
            return false;
          } else {
            return true;
          }
        }
        return false;
      }
      

      Rename "$obElement" which has the same name as the field declared at line 20.
      Open

                  $obElement = $this->getElementBySlug($sElementSlug);
      Severity: Major
      Found in components/CategoryPage.php by sonar-php

      Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

      Noncompliant Code Example

      class Foo {
        public $myField;
      
        public function doSomething() {
          $myField = 0;
          ...
        }
      }
      

      See

      Rename "$obElement" which has the same name as the field declared at line 20.
      Open

              $obElement = $this->getElementBySlug($sElementSlug);
      Severity: Major
      Found in components/CategoryPage.php by sonar-php

      Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

      Noncompliant Code Example

      class Foo {
        public $myField;
      
        public function doSomething() {
          $myField = 0;
          ...
        }
      }
      

      See

      Rename "$obElement" which has the same name as the field declared at line 20.
      Open

              $obElement = $obNestingElement->parent;
      Severity: Major
      Found in components/CategoryPage.php by sonar-php

      Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

      Noncompliant Code Example

      class Foo {
        public $myField;
      
        public function doSomething() {
          $myField = 0;
          ...
        }
      }
      

      See

      Rename "$obElement" which has the same name as the field declared at line 20.
      Open

                  $obElement = Category::active()->transWhere('slug', $sElementSlug)->first();
      Severity: Major
      Found in components/CategoryPage.php by sonar-php

      Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

      Noncompliant Code Example

      class Foo {
        public $myField;
      
        public function doSomething() {
          $myField = 0;
          ...
        }
      }
      

      See

      There are no issues that match your filters.

      Category
      Status