Sign upLogin

oc-shopaholic/oc-shopaholic-plugin

View on GitHub
Star
components/PromoBlockPage.php

Summary

Maintainability
A
25 mins
Test Coverage

Function getElementObject has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getElementObject($sElementSlug)
    {
        if (empty($sElementSlug)) {
            return null;
        }
Severity: Minor
Found in components/PromoBlockPage.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Rename "$obElement" which has the same name as the field declared at line 19.
Open

            $obElement = PromoBlock::active()->transWhere('slug', $sElementSlug)->first();
Severity: Major
Found in components/PromoBlockPage.php by sonar-php

Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

Noncompliant Code Example

class Foo {
  public $myField;

  public function doSomething() {
    $myField = 0;
    ...
  }
}

See

There are no issues that match your filters.

Category
Status