Sign upLogin

oceanprotocol/aquarius

View on GitHub
Star
aquarius/app/assets.py

Summary

Maintainability
C
1 day
Test Coverage
A
95%

File assets.py has 418 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#
# Copyright 2023 Ocean Protocol Foundation
# SPDX-License-Identifier: Apache-2.0
#
import copy
Severity: Minor
Found in aquarius/app/assets.py - About 6 hrs to fix

    Function get_assets_names has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def get_assets_names():
    """Get names of assets as specified in the payload
    ---
    tags:
      - name
    Severity: Minor
    Found in aquarius/app/assets.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validate_remote has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def validate_remote():
    """Validate DDO content.
    ---
    tags:
      - ddo
    Severity: Minor
    Found in aquarius/app/assets.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return jsonify(names)
    Severity: Major
    Found in aquarius/app/assets.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return jsonify(get_signature_vrs(raw))
      Severity: Major
      Found in aquarius/app/assets.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return (jsonify(errors=errors), 400)
        Severity: Major
        Found in aquarius/app/assets.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return jsonify(error=f"Encountered error when validating asset: {str(e)}."), 500
          Severity: Major
          Found in aquarius/app/assets.py - About 30 mins to fix

            Function trigger_caching has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def trigger_caching():
    """Triggers manual caching of a specific transaction (MetadataCreated or MetadataUpdated event)
    ---
    tags:
      - name
            Severity: Minor
            Found in aquarius/app/assets.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status