Sign upLogin

oceanprotocol/provider

View on GitHub
Star
ocean_provider/file_types/types/smartcontract.py

Summary

Maintainability
A
2 hrs
Test Coverage
B
87%

Function validate_dict has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_dict(self) -> Tuple[bool, Any]:
        if not self.address:
            return False, "malformed smartcontract type, missing contract address"
        # validate abi
Severity: Minor
Found in ocean_provider/file_types/types/smartcontract.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return True, self
Severity: Major
Found in ocean_provider/file_types/types/smartcontract.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return False, "Missing parameters"
    Severity: Major
    Found in ocean_provider/file_types/types/smartcontract.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return False, "Missing userparams: " + ",".join(missing_inputs)
      Severity: Major
      Found in ocean_provider/file_types/types/smartcontract.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status